From 8f95ec01dc2674fabc329706f531622aaa4cba03 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Wed, 6 Aug 2025 07:27:16 -0400 Subject: [PATCH 1/3] Dynamically set `node-version-file` input When both `node-version-file` and `node-version` are passed to `actions/setup-node`, a warning is output. When inputs are empty, they are ignored. This will silence the error while keepign the same functionality. --- .github/setup-node/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/setup-node/action.yml b/.github/setup-node/action.yml index ad6552cc91e96d..a6c7814b50cded 100644 --- a/.github/setup-node/action.yml +++ b/.github/setup-node/action.yml @@ -12,7 +12,7 @@ runs: - name: Use desired version of Node.js uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: - node-version-file: '.nvmrc' + node-version-file: ${{ inputs.node-version == '' && '.nvmrc' || '' }} node-version: ${{ inputs.node-version }} check-latest: true cache: npm From da571ef969b950197c52c96686c600c0796035d6 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Wed, 6 Aug 2025 08:05:25 -0400 Subject: [PATCH 2/3] Add Node.js 24 to test matrices. --- .github/workflows/create-block.yml | 2 +- .github/workflows/unit-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/create-block.yml b/.github/workflows/create-block.yml index ad63a563a93ba1..6cdfd7754bd611 100644 --- a/.github/workflows/create-block.yml +++ b/.github/workflows/create-block.yml @@ -26,7 +26,7 @@ jobs: strategy: fail-fast: false matrix: - node: ['20', '22'] + node: ['20', '22', '24'] os: ['macos-latest', 'ubuntu-latest', 'windows-latest'] steps: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index bd77280d1afea5..301ba9f7061e2d 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -33,7 +33,7 @@ jobs: strategy: fail-fast: false matrix: - node: ['20', '22'] + node: ['20', '22', '24'] shard: ['1/4', '2/4', '3/4', '4/4'] steps: @@ -78,7 +78,7 @@ jobs: strategy: fail-fast: false matrix: - node: ['20', '22'] + node: ['20', '22', '24'] steps: - name: Checkout repository From 1ffe60a40f1c4252252e68592cf71d52d7533885 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Wed, 6 Aug 2025 15:24:15 -0400 Subject: [PATCH 3/3] Revert "Dynamically set `node-version-file` input" This reverts commit 8f95ec01dc2674fabc329706f531622aaa4cba03. --- .github/setup-node/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/setup-node/action.yml b/.github/setup-node/action.yml index a6c7814b50cded..ad6552cc91e96d 100644 --- a/.github/setup-node/action.yml +++ b/.github/setup-node/action.yml @@ -12,7 +12,7 @@ runs: - name: Use desired version of Node.js uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: - node-version-file: ${{ inputs.node-version == '' && '.nvmrc' || '' }} + node-version-file: '.nvmrc' node-version: ${{ inputs.node-version }} check-latest: true cache: npm