[TEST ONLY] RTC: Discard stale compactions when a newer one already exists#77990
Closed
ramonjd wants to merge 2 commits into
Closed
[TEST ONLY] RTC: Discard stale compactions when a newer one already exists#77990ramonjd wants to merge 2 commits into
ramonjd wants to merge 2 commits into
Conversation
…updates silently. Update collaboration.php to conditionally use Gutenberg-specific sync server and adjust REST route registration priority accordingly.
… to exclusively use Gutenberg-specific sync server. Adjust tests to reference the new class structure.
ramonjd
commented
May 6, 2026
| * @since 7.0.0 | ||
| * @access private | ||
| */ | ||
| class Gutenberg_WP_HTTP_Polling_Sync_Server { |
Member
Author
There was a problem hiding this comment.
Gutenberg-specific class exists so that tests/other functionality works in the plugin in the absence of Core's WP_HTTP_Polling_Sync_Server
Member
Author
|
Closing. #77986 exists. I didn't find it! |
|
Flaky tests detected in c450e9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25412398194
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I don't have any context on RTC and this was AI generated. I think it might be better to unblock folks by skipping the test, and wait for the experts to chime in. Skip PR here: #77991
Follow up to #77980
When a compaction arrives but a newer compaction already exists after the client's cursor, the server was storing the stale data as a regular update, but the newer compaction already subsumes that state. Discard it silently instead.
Also consolidates to a single
Gutenberg_WP_HTTP_Polling_Sync_Serverimplementation (the established override pattern for shipping fixes ahead of Core), removing the duplicateWP_HTTP_Polling_Sync_Serverclass that was never loaded when Core's version exists.What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
A lot