Skip to content

RTC: Skip flaky stale-compaction test pending fix#77991

Closed
ramonjd wants to merge 1 commit into
trunkfrom
skip/rtc-polling-sync-test
Closed

RTC: Skip flaky stale-compaction test pending fix#77991
ramonjd wants to merge 1 commit into
trunkfrom
skip/rtc-polling-sync-test

Conversation

@ramonjd
Copy link
Copy Markdown
Member

@ramonjd ramonjd commented May 6, 2026

What

Marks test_sync_stale_compaction_succeeds_when_newer_compaction_exists as skipped while the stale compaction handling fix is worked out separately.

Why

Noticed after #77980 was merged.

Tests_Collaboration_WpHttpPollingSyncServer::test_sync_stale_compaction_succeeds_when_newer_compaction_exists was failing.

The main reason, I think, is because WP_HTTP_Polling_Sync_Server is being loaded from Core now and collaboration.php skips it. Might need a dedicated Gutenberg_WP_HTTP_Polling_Sync_Server or something.

I tried a more meaningful fix in #77990 but I'd rather leave that to folks who have greater context.

Testing

CI should pass.

Use of AI

None.

@ramonjd ramonjd self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd requested a review from alecgeatches May 6, 2026 02:07
@ramonjd ramonjd added [Type] Flaky Test Auto-generated flaky test report issue No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core labels May 6, 2026
@ramonjd
Copy link
Copy Markdown
Member Author

ramonjd commented May 6, 2026

closing in favour of #77986 - I didn't see it! 🤦🏻

@ramonjd ramonjd closed this May 6, 2026
@ramonjd ramonjd deleted the skip/rtc-polling-sync-test branch May 6, 2026 02:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Flaky tests detected in f1c5dc0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25412628190
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Flaky Test Auto-generated flaky test report issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant