Skip to content

Revert "Icons: maintain absolute stroke-width regardless of icon-size (#78774)"#78854

Merged
t-hamano merged 1 commit into
trunkfrom
revert/update/icons-stroke-width-support
Jun 1, 2026
Merged

Revert "Icons: maintain absolute stroke-width regardless of icon-size (#78774)"#78854
t-hamano merged 1 commit into
trunkfrom
revert/update/icons-stroke-width-support

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented Jun 1, 2026

What?

This reverts commit 86c5139 (#78774).

Why?

We applied an approach that maintains an absolute stroke width regardless of icon size to the square icon. However, this icon caused unintended changes in the editor. The cause is the following CSS.

.components-button svg {
    fill: currentColor;
}

Let's revert #78774 and explore a more ideal approach in #78808.

How?

Testing Instructions

Check the Zoom out button.

Screenshots or screencast

Before After
image image

Use of AI Tools

None

@github-actions github-actions Bot added the [Package] Icons /packages/icons label Jun 1, 2026
@t-hamano t-hamano self-assigned this Jun 1, 2026
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Icons Related to Icon registration API and Icon REST API labels Jun 1, 2026
@t-hamano t-hamano requested a review from jasmussen June 1, 2026 11:31
@t-hamano t-hamano marked this pull request as ready for review June 1, 2026 11:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much appreciate all your help with this work!

@t-hamano t-hamano merged commit 6a74870 into trunk Jun 1, 2026
52 checks passed
@t-hamano t-hamano deleted the revert/update/icons-stroke-width-support branch June 1, 2026 12:23
@github-actions github-actions Bot added this to the Gutenberg 23.4 milestone Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Icons Related to Icon registration API and Icon REST API [Package] Icons /packages/icons [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants