Merge pull request #972 from WordPress/error-type-plugin-headers

Change error type for fields in plugin headers

Author: ernilambar

includes/Checker/Checks/Plugin_Repo/Plugin_Header_Fields_Check.php

@@ -83,7 +83,7 @@ public function run( Check_Result $result ) {
 
 		if ( ! empty( $plugin_header['Name'] ) ) {
 			if ( in_array( $plugin_header['Name'], array( 'Plugin Name', 'My Basics Plugin' ), true ) ) {
-				$this->add_result_warning_for_file(
+				$this->add_result_error_for_file(
 					$result,
 					sprintf(
 						/* translators: %s: plugin header field */
@@ -95,7 +95,7 @@ public function run( Check_Result $result ) {
 					0,
 					0,
 					'',
-					6
+					7
 				);
 			} else {
 				$valid_chars_count = preg_match_all( '/[a-z0-9]/i', $plugin_header['Name'] );
@@ -121,7 +121,7 @@ public function run( Check_Result $result ) {
 
 		if ( ! empty( $plugin_header['PluginURI'] ) ) {
 			if ( true !== $this->is_valid_url( $plugin_header['PluginURI'] ) ) {
-				$this->add_result_warning_for_file(
+				$this->add_result_error_for_file(
 					$result,
 					sprintf(
 						/* translators: %s: plugin header field */
@@ -132,11 +132,11 @@ public function run( Check_Result $result ) {
 					$plugin_main_file,
 					0,
 					0,
-					'',
-					6
+					'https://developer.wordpress.org/plugins/plugin-basics/header-requirements/#header-fields',
+					7
 				);
 			} elseif ( preg_match( '/\/\/(example\.com|example\.net|example\.org)\//', $plugin_header['PluginURI'], $matches ) ) {
-				$this->add_result_warning_for_file(
+				$this->add_result_error_for_file(
 					$result,
 					sprintf(
 						/* translators: 1: plugin header field, 2: domain */
@@ -149,7 +149,7 @@ public function run( Check_Result $result ) {
 					0,
 					0,
 					'https://developer.wordpress.org/plugins/plugin-basics/header-requirements/#header-fields',
-					6
+					7
 				);
 			}
 		}
@@ -175,7 +175,7 @@ public function run( Check_Result $result ) {
 				|| str_contains( $plugin_header['Description'], 'Here is a short description of the plugin' )
 				|| str_contains( $plugin_header['Description'], 'Handle the basics with this plugin' )
 				) {
-				$this->add_result_warning_for_file(
+				$this->add_result_error_for_file(
 					$result,
 					sprintf(
 						/* translators: %s: plugin header field */
@@ -186,8 +186,8 @@ public function run( Check_Result $result ) {
 					$plugin_main_file,
 					0,
 					0,
-					'',
-					6
+					'https://developer.wordpress.org/plugins/plugin-basics/header-requirements/#header-fields',
+					7
 				);
 			}
 		}
@@ -239,15 +239,15 @@ public function run( Check_Result $result ) {
 					$plugin_main_file,
 					0,
 					0,
-					'',
+					'https://developer.wordpress.org/plugins/plugin-basics/header-requirements/#header-fields',
 					7
 				);
 			}
 		}
 
 		if ( ! empty( $plugin_header['Network'] ) ) {
 			if ( 'true' !== strtolower( $plugin_header['Network'] ) ) {
-				$this->add_result_warning_for_file(
+				$this->add_result_error_for_file(
 					$result,
 					sprintf(
 						/* translators: %s: plugin header field */
@@ -259,7 +259,7 @@ public function run( Check_Result $result ) {
 					0,
 					0,
 					'https://developer.wordpress.org/plugins/plugin-basics/header-requirements/#header-fields',
-					6
+					7
 				);
 			}
 		}

tests/phpunit/tests/Checker/Checks/Plugin_Header_Fields_Check_Tests.php

@@ -30,11 +30,11 @@ public function test_run_with_errors() {
 		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_no_license' ) ) );
 		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_missing_plugin_version' ) ) );
 		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_author_uri' ) ) );
-		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][0][0], array( 'code' => 'plugin_header_invalid_plugin_uri_domain' ) ) );
-		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][0][0], array( 'code' => 'plugin_header_invalid_plugin_description' ) ) );
+		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_plugin_uri_domain' ) ) );
+		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_plugin_description' ) ) );
+		$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_network' ) ) );
 		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][0][0], array( 'code' => 'textdomain_mismatch' ) ) );
 		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][0][0], array( 'code' => 'plugin_header_nonexistent_domain_path' ) ) );
-		$this->assertCount( 1, wp_list_filter( $warnings['load.php'][0][0], array( 'code' => 'plugin_header_invalid_network' ) ) );
 
 		if ( is_wp_version_compatible( '6.5' ) ) {
 			$this->assertCount( 1, wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_requires_plugins' ) ) );
@@ -179,9 +179,10 @@ public function test_run_with_errors_duplicated_protocol_is_valid_url() {
 		$errors = $check_result->get_errors();
 
 		$filtered_items = wp_list_filter( $errors['load.php'][0][0], array( 'code' => 'plugin_header_invalid_author_uri' ) );
+		$filtered_items = array_values( $filtered_items );
 
 		$this->assertCount( 1, $filtered_items );
-		$this->assertStringContainsString( 'Author URI', $filtered_items[1]['message'] );
-		$this->assertStringContainsString( 'is not valid', $filtered_items[1]['message'] );
+		$this->assertStringContainsString( 'Author URI', $filtered_items[0]['message'] );
+		$this->assertStringContainsString( 'is not valid', $filtered_items[0]['message'] );
 	}
 }