Merge pull request #928 from WordPress/917-tested-upto

Show tested up to minor check only when it is current major version

Author: ernilambar

includes/Checker/Checks/Plugin_Repo/Plugin_Readme_Check.php

@@ -216,12 +216,14 @@ private function check_headers( Check_Result $result, string $readme_file, Parse
 				if ( ! empty( $parser->{$field_key} ) && 'tested' === $field_key ) {
 					list( $tested_upto, ) = explode( '-', $parser->{$field_key} );
 
+					$latest_wordpress_version = $this->get_wordpress_stable_version();
+
 					$tested_upto_major = $tested_upto;
 					if ( preg_match( '#^\d.\d#', $tested_upto, $matches ) ) {
 						$tested_upto_major = $matches[0];
 					}
 
-					if ( preg_match( '/^\d+\.\d+\.\d+/', $tested_upto ) ) {
+					if ( $tested_upto_major === $latest_wordpress_version && preg_match( '/^\d+\.\d+\.\d+/', $tested_upto ) ) {
 						$this->add_result_error_for_file(
 							$result,
 							sprintf(
@@ -239,7 +241,6 @@ private function check_headers( Check_Result $result, string $readme_file, Parse
 						);
 					}
 
-					$latest_wordpress_version = $this->get_wordpress_stable_version();
 					if ( version_compare( $tested_upto_major, $latest_wordpress_version, '<' ) ) {
 						$this->add_result_error_for_file(
 							$result,

tests/phpunit/tests/Checker/Checks/Plugin_Readme_Check_Tests.php

@@ -220,7 +220,11 @@ public function test_run_with_errors_tested_upto() {
 		$this->assertCount( 1, wp_list_filter( $errors['readme.txt'][0][0], array( 'code' => 'outdated_tested_upto_header' ) ) );
 	}
 
-	public function test_run_with_errors_tested_upto_minor() {
+	public function test_run_with_errors_tested_upto_minor_same_major_version() {
+		// Target plugin has "6.1.1" is readme.
+		// Current version is set to 6.1.2.
+		set_transient( 'wp_plugin_check_latest_version_info', array( 'current' => '6.1.2' ) );
+
 		$readme_check  = new Plugin_Readme_Check();
 		$check_context = new Check_Context( UNIT_TESTS_PLUGIN_DIR . 'test-plugin-plugin-readme-errors-tested-upto-minor/load.php' );
 		$check_result  = new Check_Result( $check_context );
@@ -229,15 +233,44 @@ public function test_run_with_errors_tested_upto_minor() {
 
 		$errors = $check_result->get_errors();
 
+		delete_transient( 'wp_plugin_check_latest_version_info' );
+
 		$this->assertNotEmpty( $errors );
 		$this->assertArrayHasKey( 'readme.txt', $errors );
 
-		// Check for tested upto.
+		// Check for tested upto minor error.
 		$this->assertArrayHasKey( 0, $errors['readme.txt'] );
 		$this->assertArrayHasKey( 0, $errors['readme.txt'][0] );
 		$this->assertCount( 1, wp_list_filter( $errors['readme.txt'][0][0], array( 'code' => 'invalid_tested_upto_minor' ) ) );
 	}
 
+	public function test_run_with_errors_tested_upto_minor_different_major_version() {
+		// Target plugin has "6.1.1" is readme.
+		// Current version is set to 6.2.1.
+		set_transient( 'wp_plugin_check_latest_version_info', array( 'current' => '6.2.1' ) );
+
+		$readme_check  = new Plugin_Readme_Check();
+		$check_context = new Check_Context( UNIT_TESTS_PLUGIN_DIR . 'test-plugin-plugin-readme-errors-tested-upto-minor/load.php' );
+		$check_result  = new Check_Result( $check_context );
+
+		$readme_check->run( $check_result );
+
+		$errors = $check_result->get_errors();
+
+		delete_transient( 'wp_plugin_check_latest_version_info' );
+
+		$this->assertNotEmpty( $errors );
+		$this->assertArrayHasKey( 'readme.txt', $errors );
+
+		// Check for tested upto minor error.
+		$this->assertArrayHasKey( 0, $errors['readme.txt'] );
+		$this->assertArrayHasKey( 0, $errors['readme.txt'][0] );
+		$this->assertCount( 0, wp_list_filter( $errors['readme.txt'][0][0], array( 'code' => 'invalid_tested_upto_minor' ) ) );
+
+		// There must be outdated_tested_upto_header error.
+		$this->assertCount( 1, wp_list_filter( $errors['readme.txt'][0][0], array( 'code' => 'outdated_tested_upto_header' ) ) );
+	}
+
 	public function test_run_with_errors_missing_readme_headers() {
 		$readme_check  = new Plugin_Readme_Check();
 		$check_context = new Check_Context( UNIT_TESTS_PLUGIN_DIR . 'test-plugin-plugin-readme-errors-upgrade-notice/load.php' );