-
Notifications
You must be signed in to change notification settings - Fork 96
Add error count summary to plugin check UI #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
faisalahammad
wants to merge
9
commits into
WordPress:trunk
Choose a base branch
from
faisalahammad:fix/1113-add-error-count-summary
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4fdc53e
Add error count summary to plugin check UI
faisalahammad 31179bf
Fix lint errors in plugin-check-admin.js
faisalahammad 2e123c2
Revert unrelated changes in package-lock.json
faisalahammad 2625b54
Exclude package-lock.json from PR
faisalahammad cba93e1
Update version number to 1.9.0 in countResults() comment
faisalahammad 7ada770
Localize error and warning count strings in JS
faisalahammad d592676
Fix plural JS translation warnings
faisalahammad 4003cb1
Revert JS refactoring, use simple __() with translator comments in PHP
faisalahammad 44741fa
Address i18n and UX review feedback
faisalahammad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messageTypeis derived only fromisSuccessMessage, so a warnings-only run will still rendernotice-erroreven whenerrorCountis 0 (butwarningCount> 0). Consider deriving the notice type from the counted totals (e.g.,successwhen both 0,warningwhen only warnings,errorwhen errors > 0) so the notice styling matches the actual result severity.