Skip to content

Update i18n error codes severity#905

Merged
davidperezgar merged 2 commits into
trunkfrom
update-i18n-variable-text-severity
Apr 1, 2025
Merged

Update i18n error codes severity#905
davidperezgar merged 2 commits into
trunkfrom
update-i18n-variable-text-severity

Conversation

@ernilambar

@ernilambar ernilambar commented Apr 1, 2025

Copy link
Copy Markdown
Member

PRT team has decided to increase severity for several i18n error codes which are frequently hit in plugin submissions.

This PR:

  • Raises the severity for i18n error codes for WordPress.WP.I18n.InterpolatedVariableXXX and WordPress.WP.I18n.NonSingularStringLiteralXXX. Earlier only selective errors codes were assigned severity 7.
  • Unit tests have been added.

@ernilambar ernilambar force-pushed the update-i18n-variable-text-severity branch from 2695556 to 16a5f6c Compare April 1, 2025 04:41
@ernilambar ernilambar force-pushed the update-i18n-variable-text-severity branch from 7be3c70 to cb49631 Compare April 1, 2025 05:10
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugins Issues owned by Plugins Team labels Apr 1, 2025
@ernilambar ernilambar added this to the 1.5.0 milestone Apr 1, 2025
@ernilambar ernilambar marked this pull request as ready for review April 1, 2025 05:16
@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy

Copy link
Copy Markdown
Member

Looking at the diff, it seems these were already at severity 7, no? 🤔

@ernilambar

Copy link
Copy Markdown
Member Author

Looking at the diff, it seems these were already at severity 7, no? 🤔

Earlier only three were severity 7, WordPress.WP.I18n.InterpolatedVariableDomain, WordPress.WP.I18n.NonSingularStringLiteralContext and WordPress.WP.I18n.NonSingularStringLiteralDomain.

Now other codes will also be updated like WordPress.WP.I18n.InterpolatedVariableXXX. XXX could contain Single, Plural, etc.

@davidperezgar davidperezgar merged commit b733903 into trunk Apr 1, 2025
@davidperezgar davidperezgar deleted the update-i18n-variable-text-severity branch April 1, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Team] Plugins Issues owned by Plugins Team [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants