Skip to content

WP_UNINSTALL_PLUGIN check must be there in uninstall.php file#958

Merged
davidperezgar merged 9 commits into
WordPress:trunkfrom
hrkhal:929-wp-uninstall-plugin-constant-check-uninstall-php
Jun 23, 2025
Merged

WP_UNINSTALL_PLUGIN check must be there in uninstall.php file#958
davidperezgar merged 9 commits into
WordPress:trunkfrom
hrkhal:929-wp-uninstall-plugin-constant-check-uninstall-php

Conversation

@hrkhal
Copy link
Copy Markdown
Contributor

@hrkhal hrkhal commented Jun 5, 2025

Simple attempt at checking for a definition check for WP_UNINSTALL_PLUGIN

If a different approach would be preferred then please let me know.

Fixes #929

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hrkhal <hrkhal@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: iyut <aralle@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment thread includes/Checker/Checks/Plugin_Repo/Plugin_Uninstall_Constant_Check.php Outdated
@davidperezgar davidperezgar merged commit ad50686 into WordPress:trunk Jun 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WP_UNINSTALL_PLUGIN check must be there in uninstall.php file

3 participants