#63: Fix HTML5 validation issues#910
Open
masteradhoc wants to merge 1 commit into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes HTML5 validation issues.
Fixes #63.
Why?
The plugin's output contained several XHTML-isms and non-conforming patterns that fail HTML5 validation
How?
<input />,<img />,<br />,<hr />→ no trailing slash, across all provider and core files.disabled="disabled"→disabledon the profile page fieldset.<a>to<button>— the element has no URL destination;<a href="javascript:void(0);">is non-conforming. The JS targets it by class so no JS changes needed.href="#"to "Download Codes"<a>— HTML5 requireshrefwhendownloadis present. The JS sets the real data URI href after code generation;#is just a valid placeholder.<style>block — the block inclass-two-factor-core.phpwas already moved touser-edit.cssby Move class-two-factor-core.php login styles from inline to enqueued stylesheet #807, but was accidentally reintroduced by Move inline JS to external script files #814 while refactoring inline JS. This removes it again.Note:
type="text/javascript"andtype="text/css"inincludes/are intentionally left — those files track WordPress Core.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Drafting the implementation and PR text. Code reviewed and edited by me.
Testing Instructions
Screenshots or screencast
Changelog Entry