Apply suggestions from code review

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Author: adamsilverstein

src/wp-includes/media.php

@@ -6617,6 +6617,10 @@ function wp_add_crossorigin_attributes( string $html ): string {
 		if ( ! isset( $cross_origin_tag_attributes[ $tag ] ) ) {
 			continue;
 		}
+		$crossorigin = $processor->get_attribute( 'crossorigin' );
+		if ( null !== $crossorigin ) {
+			continue;
+		}
 
 		if ( 'AUDIO' === $tag || 'VIDEO' === $tag ) {
 			$processor->set_bookmark( 'audio-video-parent' );
@@ -6626,8 +6630,6 @@ function wp_add_crossorigin_attributes( string $html ): string {
 
 		$sought = false;
 
-		$crossorigin = $processor->get_attribute( 'crossorigin' );
-
 		$is_cross_origin = false;
 
 		foreach ( $cross_origin_tag_attributes[ $tag ] as $attr ) {
@@ -6641,7 +6643,7 @@ function wp_add_crossorigin_attributes( string $html ): string {
 			}
 		}
 
-		if ( $is_cross_origin && ! is_string( $crossorigin ) ) {
+		if ( $is_cross_origin ) {
 			if ( 'SOURCE' === $tag ) {
 				$sought = $processor->seek( 'audio-video-parent' );
 

src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -313,7 +313,7 @@ public function create_item( $request ) {
 		}
 
 		// Handle convert_format parameter.
-		if ( isset( $request['convert_format'] ) && ! $request['convert_format'] ) {
+		if ( false === $request['convert_format'] ) {
 			add_filter( 'image_editor_output_format', '__return_empty_array', 100 );
 		}
 
@@ -2031,7 +2031,7 @@ public function sideload_item( WP_REST_Request $request ) {
 			);
 		}
 
-		if ( isset( $request['convert_format'] ) && ! $request['convert_format'] ) {
+		if ( false === $request['convert_format'] ) {
 			// Prevent image conversion as that is done client-side.
 			add_filter( 'image_editor_output_format', '__return_empty_array', 100 );
 		}