chore: upgrade phpstan to v2.0

Author: justlevine

composer.json

@@ -20,7 +20,7 @@
 		"squizlabs/php_codesniffer": "3.10.3",
 		"wp-coding-standards/wpcs": "~3.1.0",
 		"phpcompatibility/phpcompatibility-wp": "~2.1.3",
-		"phpstan/phpstan": "1.12.11",
+		"phpstan/phpstan": "2.0.2",
 		"yoast/phpunit-polyfills": "^1.1.0"
 	},
 	"config": {

phpstan.neon.dist

@@ -19,6 +19,7 @@ includes:
 
 parameters:
   level: 6
+  reportUnmatchedIgnoredErrors: true
 
   ignoreErrors:
     # Inner functions aren't supported:

tests/phpstan/base.neon

@@ -62,7 +62,6 @@ parameters:
       - ../../src/wp-includes/IXR
       - ../../src/wp-includes/PHPMailer
       - ../../src/wp-includes/pomo
-      - ../../src/wp-includes/random_compat
       - ../../src/wp-includes/Requests
       - ../../src/wp-includes/SimplePie
       - ../../src/wp-includes/sodium_compat

tests/phpstan/baseline/level-0.php

@@ -2,80 +2,86 @@
 
 $ignoreErrors = [];
 $ignoreErrors[] = [
-	// identifier: variable.undefined
 	'message' => '#^Undefined variable\\: \\$transient$#',
+	'identifier' => 'variable.undefined',
 	'count' => 2,
 	'path' => __DIR__ . '/../../../src/wp-admin/includes/class-wp-debug-data.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Method WP_Filesystem_SSH2\\:\\:touch\\(\\) should return bool but return statement is missing\\.$#',
+	'identifier' => 'return.missing',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-admin/includes/class-wp-filesystem-ssh2.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Function wp_get_nav_menu_to_edit\\(\\) should return string\\|WP_Error but return statement is missing\\.$#',
+	'identifier' => 'return.missing',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-admin/includes/nav-menu.php',
 ];
 $ignoreErrors[] = [
-	// identifier: class.notFound
 	'message' => '#^Instantiated class WP_Press_This_Plugin not found\\.$#',
+	'identifier' => 'class.notFound',
+	'count' => 1,
+	'path' => __DIR__ . '/../../../src/wp-admin/press-this.php',
+];
+$ignoreErrors[] = [
+	'message' => '#^Path in include\\(\\) "/press\\-this/class\\-wp\\-press\\-this\\-plugin\\.php" is not a file or it does not exist\\.$#',
+	'identifier' => 'include.fileNotFound',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-admin/press-this.php',
 ];
 $ignoreErrors[] = [
-	// identifier: function.notFound
 	'message' => '#^Function wp_get_duotone_filter_svg not found\\.$#',
+	'identifier' => 'function.notFound',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/class-wp-theme-json.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Method WP_Customize_Background_Image_Setting\\:\\:update\\(\\) should return bool but return statement is missing\\.$#',
+	'identifier' => 'return.missing',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/customize/class-wp-customize-background-image-setting.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Method WP_Customize_Filter_Setting\\:\\:update\\(\\) should return bool but return statement is missing\\.$#',
+	'identifier' => 'return.missing',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/customize/class-wp-customize-filter-setting.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Method WP_Customize_Header_Image_Setting\\:\\:update\\(\\) should return bool but return statement is missing\\.$#',
-	'count' => 1,
+	'identifier' => 'return.missing',
+	'count' => 2,
 	'path' => __DIR__ . '/../../../src/wp-includes/customize/class-wp-customize-header-image-setting.php',
 ];
 $ignoreErrors[] = [
-	// identifier: function.notFound
 	'message' => '#^Function wp_update_https_detection_errors not found\\.$#',
+	'identifier' => 'function.notFound',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/https-detection.php',
 ];
 $ignoreErrors[] = [
-	// identifier: return.missing
 	'message' => '#^Function _wp_filter_build_unique_id\\(\\) should return string but return statement is missing\\.$#',
+	'identifier' => 'return.missing',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/plugin.php',
 ];
 $ignoreErrors[] = [
-	// identifier: unset.offset
 	'message' => '#^Cannot unset offset 0 on array\\<string, string\\>\\.$#',
+	'identifier' => 'unset.offset',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/rest-api.php',
 ];
 $ignoreErrors[] = [
-	// identifier: new.static
 	'message' => '#^Unsafe usage of new static\\(\\)\\.$#',
+	'identifier' => 'new.static',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/style-engine/class-wp-style-engine-css-rules-store.php',
 ];
 $ignoreErrors[] = [
-	// identifier: variable.undefined
 	'message' => '#^Undefined variable\\: \\$s$#',
+	'identifier' => 'variable.undefined',
 	'count' => 1,
 	'path' => __DIR__ . '/../../../src/wp-includes/template.php',
 ];