Administration: Avoid PHP type error with gmdate() in wp_dashboard_recent_posts().

This fixes an issue when a non-integer is returned by `get_the_time( 'U' )` which can occur when a plugin filters `get_the_time`. In this case, the non-relative date is displayed in the Activity dashboard widget.

Developed in #10729

Follow-up to [26690], [26242].

Props sabernhardt, vanhoucke, westonruter.
Fixes #64496.


git-svn-id: https://develop.svn.wordpress.org/trunk@61495 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/wp-admin/includes/dashboard.php

@@ -1014,16 +1014,19 @@ function wp_dashboard_recent_posts( $args ) {
 
 			$time = get_the_time( 'U' );
 
-			if ( gmdate( 'Y-m-d', $time ) === $today ) {
-				$relative = __( 'Today' );
+			if ( ! is_int( $time ) ) {
+				/* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
+				$date = get_the_date( __( 'M jS Y' ) );
+			} elseif ( gmdate( 'Y-m-d', $time ) === $today ) {
+				$date = __( 'Today' );
 			} elseif ( gmdate( 'Y-m-d', $time ) === $tomorrow ) {
-				$relative = __( 'Tomorrow' );
+				$date = __( 'Tomorrow' );
 			} elseif ( gmdate( 'Y', $time ) !== $year ) {
 				/* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
-				$relative = date_i18n( __( 'M jS Y' ), $time );
+				$date = date_i18n( __( 'M jS Y' ), $time );
 			} else {
 				/* translators: Date and time format for recent posts on the dashboard, see https://www.php.net/manual/datetime.format.php */
-				$relative = date_i18n( __( 'M jS' ), $time );
+				$date = date_i18n( __( 'M jS' ), $time );
 			}
 
 			// Use the post edit link for those who can edit, the permalink otherwise.
@@ -1033,7 +1036,7 @@ function wp_dashboard_recent_posts( $args ) {
 			printf(
 				'<li><span>%1$s</span> <a href="%2$s" aria-label="%3$s">%4$s</a></li>',
 				/* translators: 1: Relative date, 2: Time. */
-				sprintf( _x( '%1$s, %2$s', 'dashboard' ), $relative, get_the_time() ),
+				sprintf( _x( '%1$s, %2$s', 'dashboard' ), $date, get_the_time() ),
 				$recent_post_link,
 				/* translators: %s: Post title. */
 				esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $draft_or_post_title ) ),