Skip to content

Commit 3e40efc

Browse files
committed
Add TODOs for the client_id not being the expected type
1 parent 33c8dd5 commit 3e40efc

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/wp-includes/collaboration/class-wp-http-polling-collaboration-server.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ public function check_permissions( WP_REST_Request $request ) {
251251
$wp_user_id = get_current_user_id();
252252

253253
foreach ( $rooms as $room_data ) {
254+
// TODO: $client_id is actually an int<1, max> here, even though the type says it is non-empty-string (to correspond with the client_id as varchar(32) in the schema).
254255
$client_id = $room_data['client_id'];
255256
$room = $room_data['room'];
256257

@@ -352,6 +353,7 @@ public function handle_request( WP_REST_Request $request ) {
352353

353354
foreach ( $rooms as $room_request ) {
354355
$awareness = $room_request['awareness'];
356+
// TODO: $client_id is actually an int<1, max> here, even though the type says it is non-empty-string (to correspond with the client_id as varchar(32) in the schema).
355357
$client_id = $room_request['client_id'];
356358
$cursor = $room_request['after'];
357359
$room = $room_request['room'];

0 commit comments

Comments
 (0)