Embeds: Add oEmbed meta cleanup on post save

Author: SainathPoojary

src/wp-includes/class-wp-embed.php

@@ -45,6 +45,72 @@ public function __construct() {
 		// After a post is saved, cache oEmbed items via Ajax.
 		add_action( 'edit_form_advanced', array( $this, 'maybe_run_ajax_cache' ) );
 		add_action( 'edit_page_form', array( $this, 'maybe_run_ajax_cache' ) );
+
+		// Register oEmbed meta cleanup on post save.
+		add_action( 'save_post', array( $this, 'maybe_delete_orphaned_oembed_meta' ), 10, 3 );
+	}
+
+	/**
+	 * Deletes orphaned oEmbed post meta when a post is saved.
+	 *
+	 * Removes any oEmbed cache post meta entries that no longer correspond to
+	 * an embed block or auto-embed URL in the post content. This helps prevent
+	 * orphaned oEmbed cache data from accumulating when embeds are removed.
+	 *
+	 * @since 6.6.0
+	 *
+	 * @param int     $post_id Post ID.
+	 * @param WP_Post $post    Post object.
+	 */
+	public function maybe_delete_orphaned_oembed_meta( $post_id, $post ) {
+		// Only run for posts, not revisions or autosaves.
+		if ( wp_is_post_revision( $post_id ) || wp_is_post_autosave( $post_id ) ) {
+			return;
+		}
+
+		$content    = $post->post_content;
+		$embed_urls = array();
+
+		// Collect embed URLs from Gutenberg embed blocks.
+		if ( function_exists( 'has_blocks' ) && has_blocks( $content ) ) {
+			$blocks = parse_blocks( $content );
+			foreach ( $blocks as $block ) {
+				if ( isset( $block['blockName'] ) && 'core/embed' === $block['blockName'] && ! empty( $block['attrs']['url'] ) ) {
+					$embed_urls[] = $block['attrs']['url'];
+				}
+			}
+		}
+
+		// Collect classic auto-embed URLs.
+		$lines = preg_split( '/\r\n|\r|\n/', $content );
+		foreach ( $lines as $line ) {
+			$line = trim( $line );
+			if ( filter_var( $line, FILTER_VALIDATE_URL ) ) {
+				$embed_urls[] = $line;
+			}
+		}
+		$embed_urls = array_unique( $embed_urls );
+
+		// Remove orphaned oEmbed meta.
+		$meta = get_post_meta( $post_id );
+		foreach ( $meta as $meta_key => $values ) {
+			if ( 0 === strpos( $meta_key, '_oembed_' ) ) {
+				$key_suffix = substr( $meta_key, 8 );
+				$found      = false;
+				foreach ( $embed_urls as $url ) {
+					$expected_suffix = md5( $url . serialize( wp_embed_defaults( $url ) ) );
+					if ( $key_suffix === $expected_suffix ) {
+						$found = true;
+						break;
+					}
+				}
+				if ( ! $found ) {
+					delete_post_meta( $post_id, $meta_key );
+					$time_key = '_oembed_time_' . $key_suffix;
+					delete_post_meta( $post_id, $time_key );
+				}
+			}
+		}
 	}
 
 	/**

tests/phpunit/tests/oembed/deleteOrphanedOembedMeta.php

@@ -0,0 +1,41 @@
+<?php
+/**
+ * @group oembed
+ */
+class Tests_oEmbed_DeleteOrphanedOembedMeta extends WP_UnitTestCase {
+	public function test_oembed_meta_deleted_when_embed_removed() {
+		$url     = 'https://www.youtube.com/watch?v=Ok6JKHMAkH8';
+		$post_id = self::factory()->post->create(
+			array(
+				'post_content' => $url . "\nSome text.",
+			)
+		);
+
+		// Trigger oEmbed caching as core does
+		global $wp_embed;
+		$wp_embed->cache_oembed( $post_id );
+
+		$key_suffix    = md5( $url . serialize( wp_embed_defaults( $url ) ) );
+		$cachekey      = '_oembed_' . $key_suffix;
+		$cachekey_time = '_oembed_time_' . $key_suffix;
+
+		// Ensure the oEmbed meta is present after caching
+		$this->assertNotEmpty( get_post_meta( $post_id, $cachekey, true ), 'oEmbed cache meta should exist after caching.' );
+		$this->assertNotEmpty( get_post_meta( $post_id, $cachekey_time, true ), 'oEmbed time meta should exist after caching.' );
+
+		// Remove the embed from content and update the post.
+		wp_update_post(
+			array(
+				'ID'           => $post_id,
+				'post_content' => 'Some text.',
+			)
+		);
+
+		// Re-trigger oEmbed cache
+		$wp_embed->cache_oembed( $post_id );
+
+		// The oEmbed meta should be deleted after update.
+		$this->assertEmpty( get_post_meta( $post_id, $cachekey, true ), 'oEmbed cache meta should be deleted when embed is removed.' );
+		$this->assertEmpty( get_post_meta( $post_id, $cachekey_time, true ), 'oEmbed time meta should be deleted when embed is removed.' );
+	}
+}