Skip to content

Commit 76c5605

Browse files
committed
Build/Test Tools: Fix installation tests for PHP <= 7.3.
In MySQL 8.0, the default authentication plugin changed from `mysql_native_password` to `caching_sha2_password`, which is not available in PHP 7.3 and earlier. The installation testing workflow currently accounts for this, but only for PHP 7.2 & 7.3. It also does not account for a change in MySQL 8.4 which changed the related flag for controlling this from `--default-authentication-plugin` to `--authentication-policy`. This adjusts the flags and surrounding conditions to ensure the correct ones are passed for the right combinations. Props johnbillion. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62022 602fd350-edb4-49c9-b593-d223f7449a82
1 parent c604524 commit 76c5605

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

.github/workflows/install-testing.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,6 @@ jobs:
8888
- db-version: '5.0'
8989
- db-version: '5.1'
9090
- db-version: '5.5'
91-
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
92-
- php: '7.2'
93-
db-version: '8.4'
94-
- php: '7.3'
95-
db-version: '8.4'
9691
# Only test the latest innovation release.
9792
- db-version: '9.0'
9893
- db-version: '9.1'
@@ -118,7 +113,7 @@ jobs:
118113
-e MYSQL_ROOT_PASSWORD="root"
119114
-e MYSQL_DATABASE="test_db"
120115
--entrypoint sh ${{ matrix.db-type }}:${{ matrix.db-version }}
121-
-c "exec docker-entrypoint.sh mysqld${{ matrix.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), matrix.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
116+
-c "exec docker-entrypoint.sh mysqld${{ matrix.db-type == 'mysql' && contains( fromJSON('["5.4", "5.5", "5.6", "7.0", "7.1", "7.2", "7.3"]'), matrix.php ) && ( matrix.db-version == '8.4' && ' --mysql-native-password=ON --authentication-policy=mysql_native_password' || ' --default-authentication-plugin=mysql_native_password' ) || '' }}"
122117
123118
steps:
124119
- name: Set up PHP ${{ matrix.php }}

0 commit comments

Comments
 (0)