Skip to content

Commit 829a4c0

Browse files
committed
Build/Test Tools: Remove unnecessary docker branding
1 parent 9156dc3 commit 829a4c0

7 files changed

Lines changed: 23 additions & 21 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// For format details, see https://aka.ms/devcontainer.json.
22
{
33
"name": "WordPress Core Development",
4-
"dockerComposeFile": "docker-compose.yml",
4+
"dockerComposeFile": "compose.yml",
55
"service": "app",
66
"workspaceFolder": "/workspace",
77

.github/workflows/local-docker-environment.yml renamed to .github/workflows/local-development-environment.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Local Docker Environment
1+
name: Local Development Environment
22

33
on:
44
push:
@@ -9,7 +9,7 @@ on:
99
paths:
1010
# Any changes to Docker related files.
1111
- '.env.example'
12-
- 'docker-compose.yml'
12+
- 'compose.yml'
1313
# Any changes to local environment related files
1414
- 'tools/local-env/**'
1515
# These files configure npm and the task runner. Changes could affect the outcome.
@@ -22,9 +22,9 @@ on:
2222
# These files define the versions to test.
2323
- '.version-support-*.json'
2424
# Changes to this and related workflow files should always be verified.
25-
- '.github/workflows/local-docker-environment.yml'
25+
- '.github/workflows/local-development-environment.yml'
2626
- '.github/workflows/reusable-support-json-reader-v1.yml'
27-
- '.github/workflows/reusable-test-docker-environment-v1.yml'
27+
- '.github/workflows/reusable-test-local-development-environment-v1.yml'
2828
pull_request:
2929
branches:
3030
- trunk
@@ -33,7 +33,7 @@ on:
3333
paths:
3434
# Any changes to Docker related files.
3535
- '.env.example'
36-
- 'docker-compose.yml'
36+
- 'compose.yml'
3737
# Any changes to local environment related files
3838
- 'tools/local-env/**'
3939
# These files configure npm and the task runner. Changes could affect the outcome.
@@ -46,9 +46,9 @@ on:
4646
# These files define the versions to test.
4747
- '.version-support-*.json'
4848
# Changes to this and related workflow files should always be verified.
49-
- '.github/workflows/local-docker-environment.yml'
49+
- '.github/workflows/local-development-environment.yml'
5050
- '.github/workflows/reusable-support-json-reader-v1.yml'
51-
- '.github/workflows/reusable-test-docker-environment-v1.yml'
51+
- '.github/workflows/reusable-test-local-development-environment-v1.yml'
5252
workflow_dispatch:
5353

5454
# Cancels all previous workflow runs for pull requests that have not completed.
@@ -80,7 +80,7 @@ jobs:
8080
# Tests the local Docker environment.
8181
environment-tests-mysql:
8282
name: PHP ${{ matrix.php }}
83-
uses: ./.github/workflows/reusable-test-local-docker-environment-v1.yml
83+
uses: ./.github/workflows/reusable-test-local-development-environment-v1.yml
8484
permissions:
8585
contents: read
8686
needs: [ build-test-matrix ]

.github/workflows/reusable-test-local-docker-environment-v1.yml renamed to .github/workflows/reusable-test-local-development-environment-v1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#
44
# This workflow is used by `trunk` and branches >= 6.8.
55
##
6-
name: Test local Docker environment
6+
name: Test Local Development Environment
77

88
on:
99
workflow_call:

.github/workflows/test-coverage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
paths:
99
- '.github/workflows/test-coverage.yml'
1010
- '.github/workflows/reusable-phpunit-tests-v3.yml'
11-
- 'docker-compose.yml'
11+
- 'compose.yml'
1212
- 'phpunit.xml.dist'
1313
- 'tests/phpunit/multisite.xml'
1414
pull_request:
@@ -17,7 +17,7 @@ on:
1717
paths:
1818
- '.github/workflows/test-coverage.yml'
1919
- '.github/workflows/reusable-phpunit-tests-v3.yml'
20-
- 'docker-compose.yml'
20+
- 'compose.yml'
2121
- 'phpunit.xml.dist'
2222
- 'tests/phpunit/multisite.xml'
2323
# Once daily at 00:00 UTC.

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ wp-tests-config.php
104104

105105
# Files for local environment config
106106
/docker-compose.override.yml
107+
# The compose.override.yml is the new preferred Compose file name.
108+
/compose.override.yml
107109

108110
# Visual regression test diffs
109111
tests/visual-regression/specs/__snapshots__

docker-compose.yml renamed to compose.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ services:
44
# The web server container.
55
##
66
wordpress-develop:
7-
image: nginx:alpine
7+
image: docker.io/nginx:alpine
88

99
networks:
1010
- wpdevnet
@@ -32,7 +32,7 @@ services:
3232
# The PHP container.
3333
##
3434
php:
35-
image: wordpressdevelop/php:${LOCAL_PHP-latest}
35+
image: docker.io/wordpressdevelop/php:${LOCAL_PHP-latest}
3636

3737
networks:
3838
- wpdevnet
@@ -64,7 +64,7 @@ services:
6464
# The MySQL container.
6565
##
6666
mysql:
67-
image: ${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-latest}
67+
image: docker.io/${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-latest}
6868

6969
networks:
7070
- wpdevnet
@@ -95,7 +95,7 @@ services:
9595
# The WP CLI container.
9696
##
9797
cli:
98-
image: wordpressdevelop/cli:${LOCAL_PHP-latest}
98+
image: docker.io/wordpressdevelop/cli:${LOCAL_PHP-latest}
9999

100100
networks:
101101
- wpdevnet
@@ -130,7 +130,7 @@ services:
130130
# The Memcached container.
131131
##
132132
memcached:
133-
image: memcached
133+
image: docker.io/memcached:latest
134134

135135
networks:
136136
- wpdevnet

tools/local-env/scripts/utils.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ const local_env_utils = {
88
* Determines which Docker compose files are required to properly configure the local environment given the
99
* specified PHP version, database type, and database version.
1010
*
11-
* By default, only the standard docker-compose.yml file will be used.
11+
* By default, only the standard compose.yml file will be used.
1212
*
1313
* When PHP 7.2 or 7.3 is used in combination with MySQL 8.4, an override file will also be returned to ensure
1414
* that the mysql_native_password plugin authentication plugin is on and available for use.
1515
*
1616
* @return {string[]} Compose files.
1717
*/
1818
get_compose_files: function() {
19-
const composeFiles = [ 'docker-compose.yml' ];
19+
const composeFiles = [ 'compose.yml' ];
2020

21-
if ( existsSync( 'docker-compose.override.yml' ) ) {
22-
composeFiles.push( 'docker-compose.override.yml' );
21+
if ( existsSync( 'compose.override.yml' ) ) {
22+
composeFiles.push( 'compose.override.yml' );
2323
}
2424

2525
if ( process.env.LOCAL_DB_TYPE !== 'mysql' ) {

0 commit comments

Comments
 (0)