fix: enhance nav menu item validation for private post access

kushagra-goyal-14 · kushagra-goyal-14 · commit 9576fa04072a · 2025-09-04T16:10:39.000+05:30
diff --git a/src/wp-includes/nav-menu.php b/src/wp-includes/nav-menu.php
@@ -886,7 +886,11 @@ function wp_setup_nav_menu_item( $menu_item ) {
 					$menu_item->_invalid   = true;
 				}
 
-				if ( 'publish' !== get_post_status( $menu_item->object_id ) ) {
+				$post_status = get_post_status( $menu_item->object_id );
+
+				if ( 'private' === $post_status && ! current_user_can( 'read_private_posts' ) ) {
+					$menu_item->_invalid = true;
+				} elseif ( 'private' !== $post_status && ! is_post_status_viewable( $post_status ) ) {
 					$menu_item->_invalid = true;
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -886,7 +886,11 @@ function wp_setup_nav_menu_item( $menu_item ) {`
`886`	`886`	`$menu_item->_invalid = true;`
`887`	`887`	`}`
`888`	`888`
`889`		`- if ( 'publish' !== get_post_status( $menu_item->object_id ) ) {`
	`889`	`+ $post_status = get_post_status( $menu_item->object_id );`
	`890`	`+`
	`891`	`+ if ( 'private' === $post_status && ! current_user_can( 'read_private_posts' ) ) {`
	`892`	`+ $menu_item->_invalid = true;`
	`893`	`+ } elseif ( 'private' !== $post_status && ! is_post_status_viewable( $post_status ) ) {`
`890`	`894`	`$menu_item->_invalid = true;`
`891`	`895`	`}`
`892`	`896`