Skip to content

Commit ad285ee

Browse files
committed
Admin: A11y: Fix visibility of pressed button state.
Increase the style contrast between pressed and un-pressed button states by using enhanced box-shadow to differentiate. Props wildworks, mukesh27, shailu25, maulikmakwana2008, huzaifaalmesbah, sabernhardt, khushi1501, ozgursar, noruzzaman, gaisma22, sirlouen, joedolson. Fixes #64856. git-svn-id: https://develop.svn.wordpress.org/trunk@62106 602fd350-edb4-49c9-b593-d223f7449a82
1 parent bd3f983 commit ad285ee

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

src/wp-admin/css/colors/_admin.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ input[type="radio"]:focus {
174174

175175
.button-group > .button.active {
176176
border-color: var(--wp-admin-theme-color);
177-
background: rgba(var(--wp-admin-theme-color--rgb), 0.04);
177+
background: rgba(var(--wp-admin-theme-color--rgb), 0.08);
178178
}
179179

180180
.wp-ui-primary {

src/wp-includes/css/buttons.css

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,17 @@ TABLE OF CONTENTS:
190190
/* pressed state e.g. a selected setting */
191191
.wp-core-ui .button.active,
192192
.wp-core-ui .button.active:hover {
193-
background-color: rgba(var(--wp-admin-theme-color--rgb), 0.04);
194-
color: var(--wp-admin-theme-color);
193+
background-color: rgba(var(--wp-admin-theme-color--rgb), 0.08);
194+
color: var(--wp-admin-theme-color-darker-20);
195195
border-color: var(--wp-admin-theme-color);
196-
box-shadow: none;
196+
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20);
197197
}
198198

199199
.wp-core-ui .button.active:focus {
200-
border-color: var(--wp-admin-theme-color);
201-
box-shadow: 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color);
200+
background-color: rgba(var(--wp-admin-theme-color--rgb), 0.08);
201+
color: var(--wp-admin-theme-color-darker-20);
202+
border-color: var(--wp-admin-theme-color-darker-20);
203+
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20), 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color);
202204
}
203205

204206
.wp-core-ui .button[disabled],
@@ -361,17 +363,13 @@ TABLE OF CONTENTS:
361363

362364
/* pressed state e.g. a selected setting */
363365
.wp-core-ui .button-group > .button.active {
364-
background-color: #dcdcde;
365-
color: #135e96;
366-
border-color: #0a4b78;
367-
box-shadow: inset 0 2px 5px -3px #0a4b78;
366+
border-color: var(--wp-admin-theme-color);
367+
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20);
368368
}
369369

370370
.wp-core-ui .button-group > .button.active:focus {
371-
border-color: #3582c4;
372-
box-shadow:
373-
inset 0 2px 5px -3px #0a4b78,
374-
0 0 0 1px #3582c4;
371+
border-color: var(--wp-admin-theme-color);
372+
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20), 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color);
375373
}
376374

377375
/* ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)