Connectors: Normalize plugin.is_active default at registration.

Move the missing-callback fallback from `_wp_connectors_get_connector_script_module_data()` into `WP_Connector_Registry::register()`, where the registered connector now always has `plugin.is_active` set to `__return_true` when omitted. This lets every consumer call the callback unconditionally instead of repeating an `isset()` guard, and tightens the PHPStan shape so `is_active` is no longer optional on the stored array.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: t-hamano

src/wp-includes/class-wp-connector-registry.php

@@ -41,7 +41,7 @@
  *     },
  *     plugin?: array{
  *         file: non-empty-string,
- *         is_active?: callable(): bool
+ *         is_active: callable(): bool
  *     }
  * }
  */
@@ -115,9 +115,7 @@ final class WP_Connector_Registry {
 	 *                                   'hello.php').
 	 *         @type callable $is_active Optional callback to determine whether the plugin
 	 *                                   is active. Receives no arguments and must return bool.
-	 *                                   When omitted and `file` is provided, the connector is
-	 *                                   treated as active on the assumption that the plugin
-	 *                                   must be loaded in order to register itself.
+	 *                                   Defaults to `__return_true`.
 	 *     }
 	 * }
 	 * @return array|null The registered connector data on success, null on failure.
@@ -272,6 +270,10 @@ public function register( string $id, array $args ): ?array {
 			}
 		}
 
+		if ( ! isset( $connector['plugin']['is_active'] ) ) {
+			$connector['plugin']['is_active'] = '__return_true';
+		}
+
 		$this->registered_connectors[ $id ] = $connector;
 		return $connector;
 	}

src/wp-includes/connectors.php

@@ -687,12 +687,7 @@ function _wp_connectors_get_connector_script_module_data( array $data ): array {
 
 		if ( ! empty( $connector_data['plugin']['file'] ) ) {
 			$file = $connector_data['plugin']['file'];
-			if ( ! isset( $connector_data['plugin']['is_active'] ) ) {
-				// Assume plugin has registered own connector and is therefore active.
-				$is_activated = true;
-			} else {
-				$is_activated = (bool) call_user_func( $connector_data['plugin']['is_active'] );
-			}
+			$is_activated = (bool) call_user_func( $connector_data['plugin']['is_active'] );
 			$is_installed = $is_activated || 0 === validate_plugin( $file );
 
 			$connector_out['plugin'] = array(