Tests: Use a data provider in a WP_Block_Type_Registry test for invalid block names.

Includes adding missing `@covers` tags.

Follow-up to [43742], [51491].

Props sagardeshmukh.
See #64225.

git-svn-id: https://develop.svn.wordpress.org/trunk@62245 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

tests/phpunit/tests/blocks/wpBlockTypeRegistry.php

@@ -7,6 +7,8 @@
  * @since 5.0.0
  *
  * @group blocks
+ *
+ * @coversDefaultClass WP_Block_Type_Registry
  */
 class Tests_Blocks_wpBlockTypeRegistry extends WP_UnitTestCase {
 
@@ -41,57 +43,42 @@ public function tear_down() {
 	}
 
 	/**
-	 * Should reject numbers
+	 * Should reject invalid block names.
 	 *
 	 * @ticket 45097
 	 *
-	 * @expectedIncorrectUsage WP_Block_Type_Registry::register
-	 */
-	public function test_invalid_non_string_names() {
-		$result = $this->registry->register( 1, array() );
-		$this->assertFalse( $result );
-	}
-
-	/**
-	 * Should reject blocks without a namespace
+	 * @covers ::register
 	 *
-	 * @ticket 45097
+	 * @dataProvider data_invalid_block_names
 	 *
 	 * @expectedIncorrectUsage WP_Block_Type_Registry::register
 	 */
-	public function test_invalid_names_without_namespace() {
-		$result = $this->registry->register( 'paragraph', array() );
+	public function test_invalid_block_names( $name ) {
+		$result = $this->registry->register( $name, array() );
 		$this->assertFalse( $result );
 	}
 
 	/**
-	 * Should reject blocks with invalid characters
-	 *
-	 * @ticket 45097
+	 * Data provider for test_invalid_block_names().
 	 *
-	 * @expectedIncorrectUsage WP_Block_Type_Registry::register
+	 * @return array<string, array{ 0: mixed }>
 	 */
-	public function test_invalid_characters() {
-		$result = $this->registry->register( 'still/_doing_it_wrong', array() );
-		$this->assertFalse( $result );
+	public function data_invalid_block_names(): array {
+		return array(
+			'non-string name'      => array( 1 ),
+			'no namespace'         => array( 'paragraph' ),
+			'invalid characters'   => array( 'still/_doing_it_wrong' ),
+			'uppercase characters' => array( 'Core/Paragraph' ),
+		);
 	}
 
 	/**
-	 * Should reject blocks with uppercase characters
+	 * Should accept valid block names.
 	 *
 	 * @ticket 45097
 	 *
-	 * @expectedIncorrectUsage WP_Block_Type_Registry::register
-	 */
-	public function test_uppercase_characters() {
-		$result = $this->registry->register( 'Core/Paragraph', array() );
-		$this->assertFalse( $result );
-	}
-
-	/**
-	 * Should accept valid block names
-	 *
-	 * @ticket 45097
+	 * @covers ::register
+	 * @covers ::get_registered
 	 */
 	public function test_register_block_type() {
 		$name     = 'core/paragraph';
@@ -106,10 +93,12 @@ public function test_register_block_type() {
 	}
 
 	/**
-	 * Should fail to re-register the same block
+	 * Should fail to re-register the same block.
 	 *
 	 * @ticket 45097
 	 *
+	 * @covers ::register
+	 *
 	 * @expectedIncorrectUsage WP_Block_Type_Registry::register
 	 */
 	public function test_register_block_type_twice() {
@@ -125,9 +114,11 @@ public function test_register_block_type_twice() {
 	}
 
 	/**
-	 * Should accept a WP_Block_Type instance
+	 * Should accept a WP_Block_Type instance.
 	 *
 	 * @ticket 45097
+	 *
+	 * @covers ::register
 	 */
 	public function test_register_block_type_instance() {
 		$block_type = new WP_Fake_Block_Type( 'core/fake' );
@@ -137,10 +128,12 @@ public function test_register_block_type_instance() {
 	}
 
 	/**
-	 * Unregistering should fail if a block is not registered
+	 * Unregistering should fail if a block is not registered.
 	 *
 	 * @ticket 45097
 	 *
+	 * @covers ::unregister
+	 *
 	 * @expectedIncorrectUsage WP_Block_Type_Registry::unregister
 	 */
 	public function test_unregister_not_registered_block() {
@@ -149,9 +142,12 @@ public function test_unregister_not_registered_block() {
 	}
 
 	/**
-	 * Should unregister existing blocks
+	 * Should unregister existing blocks.
 	 *
 	 * @ticket 45097
+	 *
+	 * @covers ::unregister
+	 * @covers ::is_registered
 	 */
 	public function test_unregister_block_type() {
 		$name     = 'core/paragraph';
@@ -168,6 +164,8 @@ public function test_unregister_block_type() {
 
 	/**
 	 * @ticket 45097
+	 *
+	 * @covers ::get_all_registered
 	 */
 	public function test_get_all_registered() {
 		$names    = array( 'core/paragraph', 'core/image', 'core/blockquote' );