Commit c6d9646
committed
Fix: PHP 8.0 named parameters compatibility — Tasks 1, 3, and 4
Task 1: Fix reserved keyword parameter names in Core
- Rename wp_is_valid_utf8() fallback branch parameter from $string to $bytes
(utf8.php:51) to match the primary branch and ensure consistency for
PHP 8.0+ named argument callers.
- Add documentation for the parameter rename.
Task 3: Audit and wrap call_user_func_array() usage in Core
- Reviewed all 22 call_user_func_array() call sites in Core code.
- Wrapped dynamic callback calls with wp_normalize_call_user_func_args()
where $args contains user-provided or filter-derived values:
- functions.php (wp_find_hierarchy_loop_tortoise_hare): 3 call sites
- blocks.php: 8 call sites for block rendering callbacks
- interactivity-api: 1 call site for directive callbacks
- Other sites already wrapped or verified safe with numeric-only keys.
- Added documentation comment to class-wp-block-bindings-source.php:86
explaining why its call_user_func_array() is safe without wrapping.
Task 4: Escalate PHPCS rule to error severity
- Updated phpcs.xml.dist to escalate Universal.NamingConventions.NoReservedKeywordParameterNames
from warning to error, preventing future regressions of reserved keyword parameter names.
All Core call sites now properly handle PHP 8.0 named argument compatibility.1 parent e12ddb3 commit c6d9646
File tree
25 files changed
+166
-70
lines changed- src
- wp-admin
- includes
- wp-includes
- IXR
- rest-api/endpoints
- tests/phpunit/tests
25 files changed
+166
-70
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
370 | 379 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2432 | 2432 | | |
2433 | 2433 | | |
2434 | 2434 | | |
2435 | | - | |
| 2435 | + | |
2436 | 2436 | | |
2437 | 2437 | | |
2438 | 2438 | | |
| |||
2451 | 2451 | | |
2452 | 2452 | | |
2453 | 2453 | | |
2454 | | - | |
| 2454 | + | |
2455 | 2455 | | |
2456 | 2456 | | |
2457 | 2457 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
913 | 913 | | |
914 | 914 | | |
915 | 915 | | |
916 | | - | |
| 916 | + | |
917 | 917 | | |
918 | 918 | | |
919 | 919 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1212 | 1212 | | |
1213 | 1213 | | |
1214 | 1214 | | |
1215 | | - | |
| 1215 | + | |
1216 | 1216 | | |
1217 | 1217 | | |
1218 | 1218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
635 | 635 | | |
636 | 636 | | |
637 | 637 | | |
638 | | - | |
| 638 | + | |
639 | 639 | | |
640 | 640 | | |
641 | 641 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
| 440 | + | |
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | | - | |
| 293 | + | |
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
128 | | - | |
| 127 | + | |
129 | 128 | | |
130 | | - | |
131 | | - | |
| 129 | + | |
| 130 | + | |
132 | 131 | | |
133 | 132 | | |
134 | | - | |
| 133 | + | |
135 | 134 | | |
136 | 135 | | |
137 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
| |||
0 commit comments