Skip to content

Commit da76784

Browse files
committed
Administration: Sync admin-ui Page header accessibility backport from Gutenberg.
Mirror the changes from Gutenberg PR WordPress/gutenberg#78002 (which backports WordPress/gutenberg#77617 and WordPress/gutenberg#78001 to the `wp/7.0` branch) into the auto-generated wordpress-develop bundles for the Connectors and Font Library admin screens. Two of the three accessibility issues raised in the ticket are addressed by this sync: * Page heading is now an `h1` instead of an `h2`. The bundled `Header` component's default `headingLevel` is bumped from 2 to 1, and the now-redundant explicit `headingLevel: 1` overrides at the Connectors and Font Library route stages are dropped. * The inappropriate `<header>` landmark inside the page's `region` landmark is removed by dropping the `render: <header />` prop on the Stack wrapping the page header, eliminating the nested `banner` landmark. The third issue (full-white body background) still needs to land upstream in Gutenberg per the latest comment on the ticket. Bundles updated for both the readable and minified outputs of: * `src/wp-includes/build/routes/connectors-home/content.js` * `src/wp-includes/build/routes/connectors-home/content.min.js` * `src/wp-includes/build/routes/font-list/content.js` * `src/wp-includes/build/routes/font-list/content.min.js` The `version` hash in each `content.min.asset.php` is bumped to the md5 of the new minified bundle so cached browser copies are invalidated; the next official Gutenberg sync will overwrite these with the build pipeline's canonical hashes. Props joedolson, afercia, hbhalodia, wildworks. See #65100. Made-with: Cursor
1 parent 7c55fde commit da76784

6 files changed

Lines changed: 8 additions & 11 deletions

File tree

src/wp-includes/build/routes/connectors-home/content.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ var { Fill: SidebarToggleFill, Slot: SidebarToggleSlot } = (0, import_components
584584
// packages/admin-ui/build-module/page/header.mjs
585585
var import_jsx_runtime2 = __toESM(require_jsx_runtime(), 1);
586586
function Header({
587-
headingLevel = 2,
587+
headingLevel = 1,
588588
breadcrumbs,
589589
badges,
590590
title,
@@ -598,7 +598,6 @@ function Header({
598598
{
599599
direction: "column",
600600
className: "admin-ui-page__header",
601-
render: /* @__PURE__ */ (0, import_jsx_runtime2.jsx)("header", {}),
602601
children: [
603602
/* @__PURE__ */ (0, import_jsx_runtime2.jsxs)(Stack, { direction: "row", justify: "space-between", gap: "sm", children: [
604603
/* @__PURE__ */ (0, import_jsx_runtime2.jsxs)(Stack, { direction: "row", gap: "sm", align: "center", justify: "start", children: [
@@ -1604,7 +1603,6 @@ function ConnectorsPage() {
16041603
page_default,
16051604
{
16061605
title: (0, import_i18n4.__)("Connectors"),
1607-
headingLevel: 1,
16081606
subTitle: (0, import_i18n4.__)(
16091607
"All of your API keys and credentials are stored here and shared across plugins. Configure once and use everywhere."
16101608
)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives', 'wp-private-apis', 'wp-theme', 'wp-url'), 'module_dependencies' => array(array('id' => '@wordpress/a11y', 'import' => 'static'), array('id' => '@wordpress/connectors', 'import' => 'static'), array('id' => '@wordpress/route', 'import' => 'static')), 'version' => '8a0e3b7671b73b29d3ab');
1+
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-element', 'wp-i18n', 'wp-notices', 'wp-primitives', 'wp-private-apis', 'wp-theme', 'wp-url'), 'module_dependencies' => array(array('id' => '@wordpress/a11y', 'import' => 'static'), array('id' => '@wordpress/connectors', 'import' => 'static'), array('id' => '@wordpress/route', 'import' => 'static')), 'version' => '71935a2c5ccddb875336');

src/wp-includes/build/routes/connectors-home/content.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/wp-includes/build/routes/font-list/content.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ var { Fill: SidebarToggleFill, Slot: SidebarToggleSlot } = (0, import_components
810810
// packages/admin-ui/build-module/page/header.mjs
811811
var import_jsx_runtime7 = __toESM(require_jsx_runtime(), 1);
812812
function Header({
813-
headingLevel = 2,
813+
headingLevel = 1,
814814
breadcrumbs,
815815
badges,
816816
title,
@@ -824,7 +824,6 @@ function Header({
824824
{
825825
direction: "column",
826826
className: "admin-ui-page__header",
827-
render: /* @__PURE__ */ (0, import_jsx_runtime7.jsx)("header", {}),
828827
children: [
829828
/* @__PURE__ */ (0, import_jsx_runtime7.jsxs)(Stack, { direction: "row", justify: "space-between", gap: "sm", children: [
830829
/* @__PURE__ */ (0, import_jsx_runtime7.jsxs)(Stack, { direction: "row", gap: "sm", align: "center", justify: "start", children: [
@@ -15480,7 +15479,7 @@ function FontLibraryPage() {
1548015479
}))
1548115480
);
1548215481
}
15483-
return /* @__PURE__ */ React.createElement(page_default, { headingLevel: 1, title: (0, import_i18n46.__)("Fonts") }, /* @__PURE__ */ React.createElement(
15482+
return /* @__PURE__ */ React.createElement(page_default, { title: (0, import_i18n46.__)("Fonts") }, /* @__PURE__ */ React.createElement(
1548415483
Tabs3,
1548515484
{
1548615485
selectedTabId: activeTab,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-date', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-keycodes', 'wp-primitives', 'wp-private-apis', 'wp-style-engine', 'wp-theme'), 'module_dependencies' => array(array('id' => '@wordpress/a11y', 'import' => 'static'), array('id' => '@wordpress/route', 'import' => 'static')), 'version' => '87ed406cb72d86f09e6b');
1+
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-date', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-keycodes', 'wp-primitives', 'wp-private-apis', 'wp-style-engine', 'wp-theme'), 'module_dependencies' => array(array('id' => '@wordpress/a11y', 'import' => 'static'), array('id' => '@wordpress/route', 'import' => 'static')), 'version' => 'a14870d3b2c8b28383a7');

src/wp-includes/build/routes/font-list/content.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)