HTML API: Trigger active format reconstruction when reaching text nodes.

When encountering text nodes in an HTML document, the HTML parser needs
to run the active format reconstruction algorithm, even if it doesn't
stop to visit those text nodes. This is because the formats, which might
need reconstructing, will impact the breadcrumbs of all downstream nodes
from the text node.

In this patch, this process is triggered, but the text nodes are then
skipped, since the HTML Processor doesn't currently support visiting
them.

Co-authored-by: Weston Ruter <westonruter@google.com>

Author: dmsnell

src/wp-includes/html-api/class-wp-html-processor.php

@@ -623,6 +623,39 @@ private function step_in_body() {
 		$op_sigil = $this->is_tag_closer() ? '-' : '+';
 		$op       = "{$op_sigil}{$tag_name}";
 
+		if ( null === $tag_name && '#text' === $this->get_token_type() ) {
+			/*
+			 * This rule is necessary even without supporting text nodes in the
+			 * HTML Processor because the parser has to move past text nodes, and
+			 * there could be breadcrumb implications when the text triggers the
+			 * active format reconstruction.
+			 */
+			$this->reconstruct_active_formatting_elements();
+
+			$current_token = $this->bookmarks[ $this->state->current_token->bookmark_name ];
+			if (
+				1 <= $current_token->length &&
+				"\x00" === $this->html[ $current_token->start ] &&
+				strspn( $this->html, "\x00", $current_token->start, $current_token->length ) === $current_token->length
+			) {
+				// Parse error: ignore the token.
+				return $this->step();
+			}
+
+			/*
+			 * Whitespace-only text does not affect the frameset-ok flag.
+			 * It is probably inter-element whitespace, but it may also
+			 * contain character references which decode only to whitespace.
+			 */
+			$text = $this->get_modifiable_text();
+			if ( strlen( $text ) !== strspn( $text, " \t\n\f\r" ) ) {
+				$this->state->frameset_ok = false;
+			}
+
+			// @todo Add support for text nodes: insert node and return "true" where when supported.
+			return $this->step();
+		}
+
 		switch ( $op ) {
 			/*
 			 * > A start tag whose tag name is "button"

tests/phpunit/tests/html-api/wpHtmlSupportRequiredActiveFormatReconstruction.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * Unit tests for the HTML API ensuring proper handling of behaviors related to
+ * active format reconstruction.
+ *
+ * @package WordPress
+ * @subpackage HTML-API
+ *
+ * @since 6.5.0
+ *
+ * @group html-api
+ *
+ * @coversDefaultClass WP_HTML_Processor
+ */
+class Tests_HtmlApi_WpHtmlSupportRequiredActiveFormatReconstruction extends WP_UnitTestCase {
+	/**
+	 * Ensures that active formats are properly reconstructed when visiting text nodes,
+	 * verifying that the proper breadcrumbs are maintained when scanning through HTML.
+	 *
+	 * @ticket {TICKET_NUMBER}
+	 *
+	 * @since 6.5.0
+	 */
+	public function test_reconstructs_active_formats_on_text_nodes() {
+		$processor = WP_HTML_Processor::create_fragment( '<p><b>One<span><p>Two' );
+
+		$processor->next_tag( 'span' );
+		$this->assertSame(
+			array( 'HTML', 'BODY', 'P', 'B', 'SPAN' ),
+			$processor->get_breadcrumbs(),
+			'Should have identified the stack of open elements for the first text node.'
+		);
+
+		$this->assertTrue(
+			$processor->next_tag( 'p' ),
+			'Should have found second P element.'
+		);
+
+		/*
+		 * There are two ways this test could fail. One is to appropriately find the
+		 * second text node but fail to reconstruct the implicitly-closed B element.
+		 * The other way is to fail to abort when encountering the second text node
+		 * because the kind of active format reconstruction isn't supported.
+		 */
+
+		if ( $processor->next_token() ) {
+			$this->assertSame(
+				array( 'HTML', 'BODY', 'P', 'B', '#text' ),
+				$processor->get_breadcrumbs(),
+				'Should have reconstructed the implicitly-closed B element.'
+			);
+		} else {
+			$this->assertSame(
+				WP_HTML_Processor::ERROR_UNSUPPORTED,
+				$processor->get_last_error(),
+				'Should have aborted for incomplete active format reconstruction when encountering the second text node.'
+			);
+		}
+	}
+}