Apply static analysis fixes to Tests_Block_Supports_Block_Visibility

Author: westonruter

tests/phpunit/tests/block-supports/block-visibility.php

@@ -11,31 +11,29 @@
  * @covers ::wp_render_block_visibility_support
  */
 class Tests_Block_Supports_Block_Visibility extends WP_UnitTestCase {
-	/**
-	 * @var string|null
-	 */
-	private $test_block_name;
 
-	public function set_up() {
+	private ?string $test_block_name;
+
+	public function set_up(): void {
 		parent::set_up();
 		$this->test_block_name = null;
 	}
 
-	public function tear_down() {
-		unregister_block_type( $this->test_block_name );
+	public function tear_down(): void {
+		if ( $this->test_block_name ) {
+			unregister_block_type( $this->test_block_name );
+		}
 		$this->test_block_name = null;
 		parent::tear_down();
 	}
 
 	/**
 	 * Registers a new block for testing block visibility support.
 	 *
-	 * @param string $block_name Name for the test block.
-	 * @param array  $supports   Array defining block support configuration.
-	 *
-	 * @return WP_Block_Type The block type for the newly registered test block.
+	 * @param string              $block_name Name for the test block.
+	 * @param array<string, bool> $supports   Array defining block support configuration.
 	 */
-	private function register_visibility_block_with_support( $block_name, $supports = array() ) {
+	private function register_visibility_block_with_support( string $block_name, array $supports = array() ): void {
 		$this->test_block_name = $block_name;
 		register_block_type(
 			$this->test_block_name,
@@ -51,7 +49,7 @@ private function register_visibility_block_with_support( $block_name, $supports
 		);
 		$registry = WP_Block_Type_Registry::get_instance();
 
-		return $registry->get_registered( $this->test_block_name );
+		$registry->get_registered( $this->test_block_name );
 	}
 
 	/**
@@ -60,7 +58,7 @@ private function register_visibility_block_with_support( $block_name, $supports
 	 *
 	 * @ticket 64061
 	 */
-	public function test_block_visibility_support_hides_block_when_visibility_false() {
+	public function test_block_visibility_support_hides_block_when_visibility_false(): void {
 		$this->register_visibility_block_with_support(
 			'test/visibility-block',
 			array( 'visibility' => true )
@@ -87,7 +85,7 @@ public function test_block_visibility_support_hides_block_when_visibility_false(
 	 *
 	 * @ticket 64061
 	 */
-	public function test_block_visibility_support_shows_block_when_support_not_opted_in() {
+	public function test_block_visibility_support_shows_block_when_support_not_opted_in(): void {
 		$this->register_visibility_block_with_support(
 			'test/visibility-block',
 			array( 'visibility' => false )
@@ -108,10 +106,10 @@ public function test_block_visibility_support_shows_block_when_support_not_opted
 		$this->assertSame( $block_content, $result, 'Block content should remain unchanged when blockVisibility support is not opted in.' );
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_no_visibility_attribute() {
+	public function test_block_visibility_support_no_visibility_attribute(): void {
 		$this->register_visibility_block_with_support(
 			'test/block-visibility-none',
 			array( 'visibility' => true )
@@ -128,10 +126,10 @@ public function test_block_visibility_support_no_visibility_attribute() {
 		$this->assertSame( $block_content, $result, 'Block content should remain unchanged when no visibility attribute is present.' );
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_mobile_viewport_size() {
+	public function test_block_visibility_support_generated_css_with_mobile_viewport_size(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-mobile',
 			array( 'visibility' => true )
@@ -164,10 +162,10 @@ public function test_block_visibility_support_generated_css_with_mobile_viewport
 		);
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_tablet_viewport_size() {
+	public function test_block_visibility_support_generated_css_with_tablet_viewport_size(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-tablet',
 			array( 'visibility' => true )
@@ -205,10 +203,10 @@ public function test_block_visibility_support_generated_css_with_tablet_viewport
 		);
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_desktop_breakpoint() {
+	public function test_block_visibility_support_generated_css_with_desktop_breakpoint(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-desktop',
 			array( 'visibility' => true )
@@ -250,7 +248,7 @@ public function test_block_visibility_support_generated_css_with_desktop_breakpo
 	 * @ticket 64414
 	 * @ticket 64823
 	 */
-	public function test_block_visibility_support_generated_css_with_two_viewport_sizes() {
+	public function test_block_visibility_support_generated_css_with_two_viewport_sizes(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-two',
 			array( 'visibility' => true )
@@ -356,10 +354,10 @@ public function test_block_visibility_support_generated_css_with_all_viewport_si
 		);
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_empty_object() {
+	public function test_block_visibility_support_generated_css_with_empty_object(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-empty',
 			array( 'visibility' => true )
@@ -380,10 +378,10 @@ public function test_block_visibility_support_generated_css_with_empty_object()
 		$this->assertSame( $block_content, $result, 'Block content should remain unchanged when blockVisibility is an empty array.' );
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_unknown_viewport_sizes_ignored() {
+	public function test_block_visibility_support_generated_css_with_unknown_viewport_sizes_ignored(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-unknown-viewport-sizes',
 			array( 'visibility' => true )
@@ -414,10 +412,10 @@ public function test_block_visibility_support_generated_css_with_unknown_viewpor
 		);
 	}
 
-	/*
+	/**
 	 * @ticket 64414
 	 */
-	public function test_block_visibility_support_generated_css_with_empty_content() {
+	public function test_block_visibility_support_generated_css_with_empty_content(): void {
 		$this->register_visibility_block_with_support(
 			'test/viewport-empty-content',
 			array( 'visibility' => true )