Media: guard attachment icon size lookup

Author: dhrupo

src/wp-includes/media.php

@@ -953,7 +953,9 @@ function wp_get_attachment_image_src( $attachment_id, $size = 'thumbnail', $icon
 	// Get a thumbnail or intermediate image if there is one.
 	$image = image_downsize( $attachment_id, $size );
 	if ( ! $image ) {
-		$src = false;
+		$src    = false;
+		$width  = 0;
+		$height = 0;
 
 		if ( $icon ) {
 			$src = wp_mime_type_icon( $attachment_id );
@@ -962,8 +964,13 @@ function wp_get_attachment_image_src( $attachment_id, $size = 'thumbnail', $icon
 				/** This filter is documented in wp-includes/post.php */
 				$icon_dir = apply_filters( 'icon_dir', ABSPATH . WPINC . '/images/media' );
 
-				$src_file               = $icon_dir . '/' . wp_basename( $src );
-				list( $width, $height ) = wp_getimagesize( $src_file );
+				$src_file   = $icon_dir . '/' . wp_basename( $src );
+				$image_size = wp_getimagesize( $src_file );
+
+				if ( is_array( $image_size ) ) {
+					$width  = $image_size[0];
+					$height = $image_size[1];
+				}
 			}
 		}
 

tests/phpunit/tests/media.php

@@ -1547,6 +1547,31 @@ public function test_wp_get_attachment_image_url() {
 		$this->assertSame( $image[0], wp_get_attachment_image_url( $attachment_id ) );
 	}
 
+	/**
+	 * @ticket 64742
+	 */
+	public function test_wp_get_attachment_image_src_with_icon_when_icon_file_size_cannot_be_read() {
+		$post_id       = self::factory()->post->create();
+		$attachment_id = self::factory()->attachment->create_object(
+			'test.pdf',
+			$post_id,
+			array(
+				'post_mime_type' => 'application/pdf',
+				'post_type'      => 'attachment',
+			)
+		);
+
+		$filter = static function () {
+			return 'https://example.org/wp-includes/images/media/missing-icon.png';
+		};
+
+		add_filter( 'wp_mime_type_icon', $filter );
+
+		$this->assertFalse( wp_get_attachment_image_src( $attachment_id, 'thumbnail', true ) );
+
+		remove_filter( 'wp_mime_type_icon', $filter );
+	}
+
 	/**
 	 * @ticket 12235
 	 */