Script Loader: Use wp_print_script_tag() and wp_print_inline_script_tag() in _print_scripts()

Sukhendu2002 · Sukhendu2002 · commit fab6a5acac83 · 2026-05-04T13:16:41.000+05:30
diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php
@@ -2231,10 +2231,9 @@ function _print_scripts() {
 
 	if ( $concat ) {
 		if ( ! empty( $wp_scripts->print_code ) ) {
-			echo "\n<script>\n";
-			echo $wp_scripts->print_code;
-			echo sprintf( "\n//# sourceURL=%s\n", rawurlencode( 'js-inline-concat-' . $concat ) );
-			echo "</script>\n";
+			$inline_code = $wp_scripts->print_code
+				. sprintf( "\n//# sourceURL=%s", rawurlencode( 'js-inline-concat-' . $concat ) );
+			wp_print_inline_script_tag( $inline_code );
 		}
 
 		$concat       = str_split( $concat, 128 );
@@ -2245,7 +2244,7 @@ function _print_scripts() {
 		}
 
 		$src = $wp_scripts->base_url . "/wp-admin/load-scripts.php?c={$zip}" . $concatenated . '&ver=' . $wp_scripts->default_version;
-		echo "<script src='" . esc_attr( $src ) . "'></script>\n";
+		wp_print_script_tag( array( 'src' => $src ) );
 	}
 
 	if ( ! empty( $wp_scripts->print_html ) ) {
diff --git a/tests/phpunit/tests/dependencies/scripts.php b/tests/phpunit/tests/dependencies/scripts.php
@@ -2058,9 +2058,9 @@ public function test_script_concatenation() {
 		wp_print_scripts();
 		$print_scripts = get_echo( '_print_scripts' );
 
-		$expected = "<script src='/wp-admin/load-scripts.php?c=0&amp;load%5Bchunk_0%5D=one,two,three&amp;ver={$wp_version}'></script>\n";
+		$expected = "<script src=\"/wp-admin/load-scripts.php?c=0&#038;load%5Bchunk_0%5D=one,two,three&#038;ver={$wp_version}\"></script>\n";
 
-		$this->assertSame( $expected, $print_scripts );
+		$this->assertEqualHTML( $expected, $print_scripts );
 	}
 
 	/**
@@ -4093,12 +4093,11 @@ public function test_source_url_with_concat() {
 		$print_scripts = get_echo( '_print_scripts' );
 
 		$expected = <<<HTML
-
 <script>
 var one = {"key":"val"};var two = {"key":"val"};
 //# sourceURL=js-inline-concat-one%2Ctwo
 </script>
-<script src="/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=one,two&ver={$wp_version}"></script>
+<script src="/wp-admin/load-scripts.php?c=0&#038;load%5Bchunk_0%5D=one,two&#038;ver={$wp_version}"></script>
 
 HTML;
 

Original file line number	Diff line number	Diff line change
`@@ -2231,10 +2231,9 @@ function _print_scripts() {`
`2231`	`2231`
`2232`	`2232`	`if ( $concat ) {`
`2233`	`2233`	`if ( ! empty( $wp_scripts->print_code ) ) {`
`2234`		`- echo "\n<script>\n";`
`2235`		`- echo $wp_scripts->print_code;`
`2236`		`- echo sprintf( "\n//# sourceURL=%s\n", rawurlencode( 'js-inline-concat-' . $concat ) );`
`2237`		`- echo "</script>\n";`
	`2234`	`+ $inline_code = $wp_scripts->print_code`
	`2235`	`+ . sprintf( "\n//# sourceURL=%s", rawurlencode( 'js-inline-concat-' . $concat ) );`
	`2236`	`+ wp_print_inline_script_tag( $inline_code );`
`2238`	`2237`	`}`
`2239`	`2238`
`2240`	`2239`	`$concat = str_split( $concat, 128 );`
`@@ -2245,7 +2244,7 @@ function _print_scripts() {`
`2245`	`2244`	`}`
`2246`	`2245`
`2247`	`2246`	`$src = $wp_scripts->base_url . "/wp-admin/load-scripts.php?c={$zip}" . $concatenated . '&ver=' . $wp_scripts->default_version;`
`2248`		`- echo "<script src='" . esc_attr( $src ) . "'></script>\n";`
	`2247`	`+ wp_print_script_tag( array( 'src' => $src ) );`
`2249`	`2248`	`}`
`2250`	`2249`
`2251`	`2250`	`if ( ! empty( $wp_scripts->print_html ) ) {`