fix: prevent filter from overriding WP_AI_SUPPORT preference#11295
Closed
justlevine wants to merge 36 commits intoWordPress:trunkfrom
Closed
fix: prevent filter from overriding WP_AI_SUPPORT preference#11295justlevine wants to merge 36 commits intoWordPress:trunkfrom
justlevine wants to merge 36 commits intoWordPress:trunkfrom
Conversation
Co-authored-by: Weston Ruter <westonruter@gmail.com>
> phpstan: Method WP_AI_Client_Prompt_Builder::get_builder_callable() should return callable(): mixed but returns array{WordPress\AiClient\Builders\PromptBuilder, string}.
…() always returns array
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mindctrl
reviewed
Mar 24, 2026
Co-authored-by: John Parris <public@johnparris.com>
Author
|
Hey @westonruter , @gziolo would either of you mind giving this a once-over when you have a spare moment? |
westonruter
reviewed
Apr 15, 2026
westonruter
reviewed
Apr 15, 2026
Co-authored-by: Weston Ruter <westonruter@gmail.com>
gziolo
approved these changes
Apr 15, 2026
westonruter
approved these changes
Apr 15, 2026
Member
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
LGTM, if the consensus is for the constant to always win over ether filter.
Author
Confirmed. #11149 (comment) |
gziolo
added
the
props-bot
github-actions
bot
removed
the
props-bot
pento
pushed a commit
that referenced
this pull request
Apr 16, 2026
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: #11295 Follow-up to [62067]. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. git-svn-id: https://develop.svn.wordpress.org/trunk@62239 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 16, 2026
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: WordPress/wordpress-develop#11295 Follow-up to [62067]. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. Built from https://develop.svn.wordpress.org/trunk@62239 git-svn-id: http://core.svn.wordpress.org/trunk@61519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
that referenced
this pull request
Apr 16, 2026
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: #11295 Follow-up to [62067]. Reviewed by justlevine, westonruter, adamsilverstein. Merges [62239] to the 7.0 branch. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62241 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 16, 2026
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: WordPress/wordpress-develop#11295 Follow-up to [62067]. Reviewed by justlevine, westonruter, adamsilverstein. Merges [62239] to the 7.0 branch. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. Built from https://develop.svn.wordpress.org/branches/7.0@62241 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to desrosj/wordpress-develop
that referenced
this pull request
Apr 16, 2026
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: WordPress#11295 Follow-up to [62067]. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. git-svn-id: https://develop.svn.wordpress.org/trunk@62239 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64706
This PR fixes
wp_supports_ai()to early-return ifWP_SUPPORTS_AIis false, instead allowing thewp_supports_aifilter to switch the value back on even if the user/host has explicitly disabled it.Follow up to #11149
Note
This PR is based on #11149.
Relevant diff: f0c1632
Use of AI Tools
Github Copilot Autocomplete on the doc blocks.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.