Skip to content

Hooks/filters parity for preview & update functionality#11493

Open
vishalsingh098 wants to merge 2 commits intoWordPress:trunkfrom
vishalsingh098:fix/ticket-55051
Open

Hooks/filters parity for preview & update functionality#11493
vishalsingh098 wants to merge 2 commits intoWordPress:trunkfrom
vishalsingh098:fix/ticket-55051

Conversation

@vishalsingh098
Copy link
Copy Markdown

@vishalsingh098 vishalsingh098 commented Apr 9, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/55051

Here's a summary of what was changed:

[class-wp-customize-nav-menu-item-setting.php]

Removed the // @todo Add get_post_metadata filters for plugins to add their data. placeholder (line 474)
Added do_action( "customize_preview_{$this->id}", $this ) at line 484
Added do_action( "customize_preview_{$this->type}", $this ) at line 496 (both with full docblocks, @SInCE 7.1.0)
Added do_action( "customize_update_{$this->type}", $value, $this ) at line 923 before the final return

[tests/phpunit/tests/customize/nav-menu-item-setting.php]

test_preview_fires_action_hooks() — asserts both customize_preview_{id} and customize_preview_nav_menu_item fire once with the correct setting instance
test_update_fires_action_hook() — asserts customize_update_nav_menu_item fires once with the value array and correct setting instance

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @vishal-xecurify.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants