Hooks/filters parity for preview & update functionality#11493
Hooks/filters parity for preview & update functionality#11493vishalsingh098 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @vishal-xecurify. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/55051
Here's a summary of what was changed:
[class-wp-customize-nav-menu-item-setting.php]
Removed the // @todo Add get_post_metadata filters for plugins to add their data. placeholder (line 474)
Added do_action( "customize_preview_{$this->id}", $this ) at line 484
Added do_action( "customize_preview_{$this->type}", $this ) at line 496 (both with full docblocks, @SInCE 7.1.0)
Added do_action( "customize_update_{$this->type}", $value, $this ) at line 923 before the final return
[tests/phpunit/tests/customize/nav-menu-item-setting.php]
test_preview_fires_action_hooks() — asserts both customize_preview_{id} and customize_preview_nav_menu_item fire once with the correct setting instance
test_update_fires_action_hook() — asserts customize_update_nav_menu_item fires once with the value array and correct setting instance
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.