Skip to content

Site Health: Deduplicate VCS detection via WP_Automatic_Updater (#47428)#11495

Open
pranav-inamdar wants to merge 2 commits intoWordPress:trunkfrom
pranav-inamdar:fix/47428-Site-health-remove-duplicate-code-in-VCS-test
Open

Site Health: Deduplicate VCS detection via WP_Automatic_Updater (#47428)#11495
pranav-inamdar wants to merge 2 commits intoWordPress:trunkfrom
pranav-inamdar:fix/47428-Site-health-remove-duplicate-code-in-VCS-test

Conversation

@pranav-inamdar
Copy link
Copy Markdown

Summary

Removes duplicated VCS checkout detection between Site Health and the automatic updater by centralizing the filesystem walk and .svn / .git / .hg / .bzr checks.

Changes

  • Adds WP_Automatic_Updater::get_vcs_checkout_details() to return whether a VCS metadata directory was found, which ancestor path matched, and which marker (e.g. .git) was used—before the automatic_updates_is_vcs_checkout filter is applied.
  • Refactors WP_Automatic_Updater::is_vcs_checkout() to call get_vcs_checkout_details() and then apply the filter to the raw boolean, preserving existing behavior.
  • Updates WP_Site_Health_Auto_Updates::test_vcs_abspath() to use get_vcs_checkout_details( ABSPATH ) for the user-facing messages and applies automatic_updates_is_vcs_checkout once with the raw discovery result (equivalent to the previous logic when a checkout was detected).
  • Extends PHPUnit coverage in tests/phpunit/tests/admin/wpAutomaticUpdater.php for the new helper and consistency between raw discovery and the filtered is_vcs_checkout() result.

Trac ticket: https://core.trac.wordpress.org/ticket/47428


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pi-20.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants