Posts, Post Types: Fix missing array check in get_post_custom_values().#11496
Open
saratheonline wants to merge 1 commit intoWordPress:trunkfrom
Open
Posts, Post Types: Fix missing array check in get_post_custom_values().#11496saratheonline wants to merge 1 commit intoWordPress:trunkfrom
saratheonline wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Posts, Post Types: Fix missing array check in get_post_custom_values().
`get_post_custom()` can return `false` for an invalid post ID or an empty
string for a non-existing post. `get_post_custom_values()` accessed the
result as an array without first verifying it is one, triggering a PHP
warning on PHP 8+.
Adds an `is_array()` guard consistent with the sibling function
`get_post_custom_keys()`, which already handles this case correctly.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-65044
Posts, Post Types: Fix missing array check in get_post_custom_values().
get_post_custom()can returnfalsefor an invalid post ID or an emptystring for a non-existing post.
get_post_custom_values()accessed theresult as an array without first verifying it is one, triggering a PHP
warning on PHP 8+.
Adds an
is_array()guard consistent with the sibling functionget_post_custom_keys(), which already handles this case correctly.Fixes #65044
Posts, Post Types: Fix missing array check in get_post_custom_values().
get_post_custom()can returnfalsefor an invalid post ID or an emptystring for a non-existing post.
get_post_custom_values()accessed theresult as an array without first verifying it is one, triggering a PHP
warning on PHP 8+.
Adds an
is_array()guard consistent with the sibling functionget_post_custom_keys(), which already handles this case correctly.Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.