Skip to content

Fixing 302 redirect for URLs with no extensions#11512

Open
anukasha-mo wants to merge 5 commits intoWordPress:trunkfrom
anukasha-mo:fix/31689-media-play-302-redirect
Open

Fixing 302 redirect for URLs with no extensions#11512
anukasha-mo wants to merge 5 commits intoWordPress:trunkfrom
anukasha-mo:fix/31689-media-play-302-redirect

Conversation

@anukasha-mo
Copy link
Copy Markdown

Summary of my changes:

  • Updated wp_audio_shortcode() and wp_video_shortcode() to only return a plain link when the URL does not have any extension.
  • Made the type attribute on tags conditional i.e. when the MIME type cannot be determined (redirect URLs), the type attribute is omitted entirely rather than rendered as type="", which allows the browser to probe the MIME type itself (apparently that's the same thing YouTube and Vimeo embeds do).

Trac ticket: https://core.trac.wordpress.org/ticket/31689


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props anukasha.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant