Skip to content

Fixing 302 redirect for URLs with no extensions #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anukasha-mo wants to merge 5 commits into
base: trunk
Choose a base branch
from
+60 −11
Open

Fixing 302 redirect for URLs with no extensions #11512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
188cec3
Merge remote-tracking branch 'upstream/trunk' into trunk
anukasha-mo Sep 12, 2025
d8a555d
Merge remote-tracking branch 'upstream/trunk' into trunk
anukasha-mo Apr 3, 2026
74af0c5
Merge remote-tracking branch 'upstream/trunk' into trunk
anukasha-mo Apr 8, 2026
570cc92
Merge remote-tracking branch 'upstream/trunk' into trunk
anukasha-mo Apr 9, 2026
2a9b332
fixing no extension urls
anukasha-mo Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions src/wp-includes/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3468,9 +3468,10 @@ function wp_audio_shortcode( $attr, $content = '' ) {

$primary = false;
if ( ! empty( $atts['src'] ) ) {
$type = wp_check_filetype( $atts['src'], wp_get_mime_types() );
$type = wp_check_filetype( $atts['src'], wp_get_mime_types() );
$has_extension = (bool) pathinfo( wp_parse_url( $atts['src'], PHP_URL_PATH ), PATHINFO_EXTENSION );

if ( ! in_array( strtolower( $type['ext'] ), $default_types, true ) ) {
if ( $has_extension && ! in_array( strtolower( $type['ext'] ), $default_types, true ) ) {
return sprintf( '<a class="wp-embedded-audio" href="%s">%s</a>', esc_url( $atts['src'] ), esc_html( $atts['src'] ) );
}

Expand Down Expand Up @@ -3567,17 +3568,21 @@ function wp_audio_shortcode( $attr, $content = '' ) {

$html = sprintf( '<audio %s controls="controls">', implode( ' ', $attr_strings ) );
$fileurl = '';
$source = '<source type="%s" src="%s" />';

foreach ( $default_types as $fallback ) {
if ( ! empty( $atts[ $fallback ] ) ) {
if ( empty( $fileurl ) ) {
$fileurl = $atts[ $fallback ];
}

$type = wp_check_filetype( $atts[ $fallback ], wp_get_mime_types() );
$url = add_query_arg( '_', $instance, $atts[ $fallback ] );
$html .= sprintf( $source, $type['type'], esc_url( $url ) );
$type = wp_check_filetype( $atts[ $fallback ], wp_get_mime_types() );
$url = add_query_arg( '_', $instance, $atts[ $fallback ] );

if ( ! empty( $type['type'] ) ) {
$html .= sprintf( '<source type="%s" src="%s" />', $type['type'], esc_url( $url ) );
} else {
$html .= sprintf( '<source src="%s" />', esc_url( $url ) );
}
}
}

Expand Down Expand Up @@ -3723,9 +3728,10 @@ function wp_video_shortcode( $attr, $content = '' ) {
$is_youtube = ( preg_match( $yt_pattern, $atts['src'] ) );

if ( ! $is_youtube && ! $is_vimeo ) {
$type = wp_check_filetype( $atts['src'], wp_get_mime_types() );
$type = wp_check_filetype( $atts['src'], wp_get_mime_types() );
$has_extension = (bool) pathinfo( wp_parse_url( $atts['src'], PHP_URL_PATH ), PATHINFO_EXTENSION );

if ( ! in_array( strtolower( $type['ext'] ), $default_types, true ) ) {
if ( $has_extension && ! in_array( strtolower( $type['ext'] ), $default_types, true ) ) {
return sprintf( '<a class="wp-embedded-video" href="%s">%s</a>', esc_url( $atts['src'] ), esc_html( $atts['src'] ) );
}
}
Expand Down Expand Up @@ -3845,7 +3851,6 @@ function wp_video_shortcode( $attr, $content = '' ) {

$html = sprintf( '<video %s controls="controls">', implode( ' ', $attr_strings ) );
$fileurl = '';
$source = '<source type="%s" src="%s" />';

foreach ( $default_types as $fallback ) {
if ( ! empty( $atts[ $fallback ] ) ) {
Expand All @@ -3859,8 +3864,13 @@ function wp_video_shortcode( $attr, $content = '' ) {
} else {
$type = wp_check_filetype( $atts[ $fallback ], wp_get_mime_types() );
}
$url = add_query_arg( '_', $instance, $atts[ $fallback ] );
$html .= sprintf( $source, $type['type'], esc_url( $url ) );
$url = add_query_arg( '_', $instance, $atts[ $fallback ] );

if ( ! empty( $type['type'] ) ) {
$html .= sprintf( '<source type="%s" src="%s" />', $type['type'], esc_url( $url ) );
} else {
$html .= sprintf( '<source src="%s" />', esc_url( $url ) );
}
}
}

Expand Down
39 changes: 39 additions & 0 deletions tests/phpunit/tests/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,25 @@ public function test_wp_audio_shortcode_with_bad_attr() {
);
}

/**
* Tests that a URL with no file extension (e.g. a 302 redirect) renders
* an audio player instead of a plain link.
*
* @ticket 31689
*/
public function test_wp_audio_shortcode_with_redirect_url() {
$actual = wp_audio_shortcode(
array(
'src' => 'https://onedrive.live.com/download?resid=123',
)
);

$this->assertStringContainsString( '<audio', $actual, 'Should render an audio player, not a link.' );
$this->assertStringNotContainsString( '<a class="wp-embedded-audio"', $actual, 'Should not render a fallback link.' );
$this->assertStringContainsString( 'src="https://onedrive.live.com/download?resid=123', $actual, 'Source URL should be present.' );
$this->assertStringNotContainsString( 'type=""', $actual, 'Source tag should not have an empty type attribute.' );
}

/**
* @ticket 35367
*/
Expand Down Expand Up @@ -1068,6 +1087,26 @@ public function test_wp_video_shortcode_with_bad_attr() {
);
}

/**
* Tests that a URL with no file extension (e.g. a 302 redirect) renders
* a video player instead of a plain link.
*
* @ticket 31689
* @depends test_video_shortcode_body
*/
public function test_wp_video_shortcode_with_redirect_url() {
$actual = wp_video_shortcode(
array(
'src' => 'https://onedrive.live.com/download?resid=123',
)
);

$this->assertStringContainsString( '<video', $actual, 'Should render a video player, not a link.' );
$this->assertStringNotContainsString( '<a class="wp-embedded-video"', $actual, 'Should not render a fallback link.' );
$this->assertStringContainsString( 'src="https://onedrive.live.com/download?resid=123', $actual, 'Source URL should be present.' );
$this->assertStringNotContainsString( 'type=""', $actual, 'Source tag should not have an empty type attribute.' );
}

/**
* @ticket 35367
* @ticket 54788
Expand Down
Loading