Skip to content

Nonce check order flaw in post-quickdraft-save #11538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajeshcpr wants to merge 1 commit into from
Closed

Nonce check order flaw in post-quickdraft-save #11538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/wp-admin/post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@
switch ( $action ) {
case 'post-quickdraft-save':
// Check nonce and capabilities.
$nonce = $_REQUEST['_wpnonce'];
$nonce = isset( $_REQUEST['_wpnonce'] ) ? $_REQUEST['_wpnonce'] : '';
$post_id = absint( $_REQUEST['post_ID'] ?? 0 );

Check failure on line 76 in src/wp-admin/post.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
$error_msg = false;

// For output of the Quick Draft dashboard widget.
require_once ABSPATH . 'wp-admin/includes/dashboard.php';

if ( ! wp_verify_nonce( $nonce, 'add-post' ) ) {
if ( ! $post_id || ! wp_verify_nonce( $nonce, 'add-post' ) ) {
$error_msg = __( 'Unable to submit this form, please refresh and try again.' );
}

Expand All @@ -90,7 +91,14 @@
return wp_dashboard_quick_press( $error_msg );
}

$post = get_post( $_REQUEST['post_ID'] );
$post = get_post( $post_id );
if ( ! $post ) {
$error_msg = __( 'Unable to submit this form, please refresh and try again.' );
}

if ( $error_msg ) {
return wp_dashboard_quick_press( $error_msg );
}
check_admin_referer( 'add-' . $post->post_type );

$_POST['comment_status'] = get_default_comment_status( $post->post_type );
Expand Down
Loading