Skip to content

Fix: Media upload from the post edit screen shows an inaccurate number when uploading multiple media files #11585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbhalodia wants to merge 3 commits into
base: trunk
Choose a base branch
from
+114 −2
Open

Fix: Media upload from the post edit screen shows an inaccurate number when uploading multiple media files #11585

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a4915f
Fix the issue for number count in media modal
hbhalodia Apr 16, 2026
953f13f
Add QUnit test case for the attachment model
hbhalodia May 4, 2026
a50a490
Remove backbone as not needed
hbhalodia May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/js/media/models/attachments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@ var Attachments = Backbone.Collection.extend(/** @lends wp.media.model.Attachmen
this.observers.push( attachments );

attachments.on( 'add change remove', this._validateHandler, this );
attachments.on( 'add', this._addToTotalAttachments, this );
attachments.on( 'remove', this._removeFromTotalAttachments, this );
attachments.on( 'reset', this._validateAllHandler, this );
this.validateAll( attachments );
return this;
Expand Down Expand Up @@ -310,6 +308,11 @@ var Attachments = Backbone.Collection.extend(/** @lends wp.media.model.Attachmen
this.reset( [], { silent: true } );
this.observe( attachments );

// Bind total attachment count tracking only to the mirrored query
// collection, not to additional observed collections (e.g. selection).
attachments.on( 'add', this._addToTotalAttachments, this );
attachments.on( 'remove', this._removeFromTotalAttachments, this );

// Used for the search results.
this.trigger( 'attachments:received', this );
return this;
Expand Down
Loading