Toolbar: normalize admin bar title entities#11612
Open
dhrupo wants to merge 1 commit intoWordPress:trunkfrom
Open
Toolbar: normalize admin bar title entities#11612dhrupo wants to merge 1 commit intoWordPress:trunkfrom
dhrupo wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize HTML entities when rendering admin bar node titles without escaping valid markup used by core and plugins.
Problem
WP_Admin_Bar::_render_item()outputs$node->titledirectly. This means text likeThis & thatis rendered with a literal&instead of a normalized&, while broad escaping approaches would break existing admin bar titles that intentionally include HTML.Trac ticket: https://core.trac.wordpress.org/ticket/62545
Solution
Use
wp_kses_normalize_entities()when rendering the admin bar title. This normalizes entities in text content while preserving valid embedded markup.Testing
Added a PHPUnit regression test covering an admin bar title that includes both HTML markup and an ampersand.
Verified in the configured local
wordpress-developenvironment with:node ./tools/local-env/scripts/docker.js exec --user wp_php php ./vendor/bin/phpunit --filter test_admin_bar_normalizes_title_entities_without_escaping_html tests/phpunit/tests/adminbar.phpnode ./tools/local-env/scripts/docker.js exec --user wp_php php ./vendor/bin/phpunit tests/phpunit/tests/adminbar.php