Administration: Replace pure white body background on Font Library and Connectors pages#11615
Closed
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
Closed
Administration: Replace pure white body background on Font Library and Connectors pages#11615itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…d Connectors pages.
The `wp-admin` integrated wrappers for the Font Library (`font-library.php`) and
the new Connectors page (`options-connectors.php`) set an inline `body { background: #fff; }`,
which is against established accessibility and UX best practices ("Never use full white"),
causes white-on-white content cards to blend into the page background, and is inconsistent
with every other core admin screen.
This replaces the pure white override with `#f0f0f1`, the standard `wp-admin` body
background color defined in `wp-admin/css/common.css`. The change restores visual
separation between the white `.components-item` cards and their surrounding chrome
and aligns these pages with the rest of the core admin UI.
Remaining accessibility items from the ticket (inappropriate `<header>` landmark
and ARIA landmark nesting) live in the Gutenberg `@wordpress/admin-ui` Page component
and will be picked up on the next Gutenberg package sync.
Props joedolson, afercia, hbhalodia, wildworks.
See #65100.
Made-with: Cursor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Let me close this based on https://core.trac.wordpress.org/ticket/65100#comment:8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65100
Summary
Ticket #65100 reports several accessibility issues in the admin Font Library, and in comment #5 @afercia noted that the new Connectors page at
wp-admin/options-connectors.php(introduced in 7.0) uses the same pattern and shares those issues — including a pure white body background that is inconsistent with the rest of core admin and against documented accessibility/UX best practice ("Never use full white", comment #5).Both
page-wp-admin.phpwrapper files add this inline style:This causes the white content cards (
.components-item) to blend into the body background and is inconsistent with every other core admin screen, which use#f0f0f1(defined insrc/wp-admin/css/common.css, line 225).This PR changes that override to
#f0f0f1on both pages so they match the rest of the core admin UI and give the white cards visible contrast with their surroundings — directly addressing the background-color concern from comments #5 and #6 on the ticket.Files changed
src/wp-includes/build/pages/font-library/page-wp-admin.phpsrc/wp-includes/build/pages/options-connectors/page-wp-admin.phpBoth are single-line changes:
background: #fff;→background: #f0f0f1;.Not in scope for this PR
The other accessibility items from the ticket are rendered by the Gutenberg
@wordpress/admin-uiPage/Headercomponent (compiled intosrc/wp-includes/build/routes/**), so the fix has to land in Gutenberg and will sync down on the next package update:<header>landmark on the page title block — comment Fix 35293 #4; tracked in WordPress/gutenberg#77481.Once those Gutenberg fixes land and the build sync regenerates these files, the
background: #f0f0f1;value in this PR is consistent with the plan in comment #6 (latest Gutenberg uses a near-white, not pure white).Test plan
wp-admin/options-connectors.php(Settings → Connectors) and confirm the body background matches the rest of wp-admin (#f0f0f1) and the connector cards visually stand out.wp-admin/font-library.php(Appearance → Fonts) and confirm the same.wp-admin/options-general.phpto confirm consistency.Props joedolson, afercia, hbhalodia, wildworks.