Skip to content

Administration: Replace pure white body background on Font Library and Connectors pages#11615

Closed
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
itzmekhokan:fix/65100
Closed

Administration: Replace pure white body background on Font Library and Connectors pages#11615
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
itzmekhokan:fix/65100

Conversation

@itzmekhokan
Copy link
Copy Markdown

@itzmekhokan itzmekhokan commented Apr 21, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/65100

Summary

Ticket #65100 reports several accessibility issues in the admin Font Library, and in comment #5 @afercia noted that the new Connectors page at wp-admin/options-connectors.php (introduced in 7.0) uses the same pattern and shares those issues — including a pure white body background that is inconsistent with the rest of core admin and against documented accessibility/UX best practice ("Never use full white", comment #5).

Both page-wp-admin.php wrapper files add this inline style:

body {
    background: #fff;
}

This causes the white content cards (.components-item) to blend into the body background and is inconsistent with every other core admin screen, which use #f0f0f1 (defined in src/wp-admin/css/common.css, line 225).

This PR changes that override to #f0f0f1 on both pages so they match the rest of the core admin UI and give the white cards visible contrast with their surroundings — directly addressing the background-color concern from comments #5 and #6 on the ticket.

Files changed

  • src/wp-includes/build/pages/font-library/page-wp-admin.php
  • src/wp-includes/build/pages/options-connectors/page-wp-admin.php

Both are single-line changes: background: #fff;background: #f0f0f1;.

Not in scope for this PR

The other accessibility items from the ticket are rendered by the Gutenberg @wordpress/admin-ui Page/Header component (compiled into src/wp-includes/build/routes/**), so the fix has to land in Gutenberg and will sync down on the next package update:

Once those Gutenberg fixes land and the build sync regenerates these files, the background: #f0f0f1; value in this PR is consistent with the plan in comment #6 (latest Gutenberg uses a near-white, not pure white).

Test plan

  • Load wp-admin/options-connectors.php (Settings → Connectors) and confirm the body background matches the rest of wp-admin (#f0f0f1) and the connector cards visually stand out.
  • Load wp-admin/font-library.php (Appearance → Fonts) and confirm the same.
  • Confirm no visual regression elsewhere on those two screens.
  • Compare side-by-side with wp-admin/options-general.php to confirm consistency.

Props joedolson, afercia, hbhalodia, wildworks.

…d Connectors pages.

The `wp-admin` integrated wrappers for the Font Library (`font-library.php`) and
the new Connectors page (`options-connectors.php`) set an inline `body { background: #fff; }`,
which is against established accessibility and UX best practices ("Never use full white"),
causes white-on-white content cards to blend into the page background, and is inconsistent
with every other core admin screen.

This replaces the pure white override with `#f0f0f1`, the standard `wp-admin` body
background color defined in `wp-admin/css/common.css`. The change restores visual
separation between the white `.components-item` cards and their surrounding chrome
and aligns these pages with the rest of the core admin UI.

Remaining accessibility items from the ticket (inappropriate `<header>` landmark
and ARIA landmark nesting) live in the Gutenberg `@wordpress/admin-ui` Page component
and will be picked up on the next Gutenberg package sync.

Props joedolson, afercia, hbhalodia, wildworks.
See #65100.

Made-with: Cursor
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
Copy link
Copy Markdown
Contributor

Let me close this based on https://core.trac.wordpress.org/ticket/65100#comment:8.

@t-hamano t-hamano closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants