Administration: Sync admin-ui Page header accessibility backport from Gutenberg#11789
Open
itzmekhokan wants to merge 2 commits intoWordPress:trunkfrom
Open
Administration: Sync admin-ui Page header accessibility backport from Gutenberg#11789itzmekhokan wants to merge 2 commits intoWordPress:trunkfrom
itzmekhokan wants to merge 2 commits intoWordPress:trunkfrom
Conversation
… Gutenberg. Mirror the changes from Gutenberg PR WordPress/gutenberg#78002 (which backports WordPress/gutenberg#77617 and WordPress/gutenberg#78001 to the `wp/7.0` branch) into the auto-generated wordpress-develop bundles for the Connectors and Font Library admin screens. Two of the three accessibility issues raised in the ticket are addressed by this sync: * Page heading is now an `h1` instead of an `h2`. The bundled `Header` component's default `headingLevel` is bumped from 2 to 1, and the now-redundant explicit `headingLevel: 1` overrides at the Connectors and Font Library route stages are dropped. * The inappropriate `<header>` landmark inside the page's `region` landmark is removed by dropping the `render: <header />` prop on the Stack wrapping the page header, eliminating the nested `banner` landmark. The third issue (full-white body background) still needs to land upstream in Gutenberg per the latest comment on the ticket. Bundles updated for both the readable and minified outputs of: * `src/wp-includes/build/routes/connectors-home/content.js` * `src/wp-includes/build/routes/connectors-home/content.min.js` * `src/wp-includes/build/routes/font-list/content.js` * `src/wp-includes/build/routes/font-list/content.min.js` The `version` hash in each `content.min.asset.php` is bumped to the md5 of the new minified bundle so cached browser copies are invalidated; the next official Gutenberg sync will overwrite these with the build pipeline's canonical hashes. Props joedolson, afercia, hbhalodia, wildworks. See #65100. Made-with: Cursor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the changes from Gutenberg PR WordPress/gutenberg#78002 (which backports WordPress/gutenberg#77617 and WordPress/gutenberg#78001 to the
wp/7.0branch) into the auto-generated wordpress-develop bundles for the Connectors and Font Library admin screens.Two of the three accessibility issues raised in the ticket are addressed by this sync:
h1instead of anh2. The bundledHeadercomponent's defaultheadingLevelis bumped from 2 to 1, and the now-redundant explicitheadingLevel: 1overrides at the Connectors and Font Library route stages are dropped.<header>landmark inside the page'sregionlandmark is removed by dropping therender: <header />prop on the Stack wrapping the page header, eliminating the nestedbannerlandmark.The third issue (full-white body background) still needs to land upstream in Gutenberg per the latest comment on the ticket.
Bundles updated for both the readable and minified outputs of:
src/wp-includes/build/routes/connectors-home/content.jssrc/wp-includes/build/routes/connectors-home/content.min.jssrc/wp-includes/build/routes/font-list/content.jssrc/wp-includes/build/routes/font-list/content.min.jsThe
versionhash in eachcontent.min.asset.phpis bumped to the md5 of the new minified bundle so cached browser copies are invalidated; the next official Gutenberg sync will overwrite these with the build pipeline's canonical hashes.Props joedolson, afercia, hbhalodia, wildworks.
See #65100.
Trac ticket: https://core.trac.wordpress.org/ticket/65100