New function to retrieve page IDs/Permalinks/Titles based on template…#8073
New function to retrieve page IDs/Permalinks/Titles based on template…#8073AakifKadiwala wants to merge 12 commits intoWordPress:trunkfrom
Conversation
… file name Queries pages using a specified template file and returns an array of IDs, permalinks, or titles based on the provided field parameter.
|
Hi @AakifKadiwala! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| /** | ||
| * Retrieves page IDs, permalinks, or titles based on a template file name. | ||
| * | ||
| * Queries pages using a specified template file and returns an array of |
There was a problem hiding this comment.
| * Queries pages using a specified template file and returns an array of | |
| * Queries pages using a specified template file and returns an array of |
|
Hi @mukeshpanchal27 |
Added condition to prevent the fatal error on missing capabilities in array.
| if ( $query->have_posts() ) { | ||
| $template_page_ids = $query->posts; | ||
| if ( 'ID' === $field ) { | ||
| wp_reset_postdata(); |
There was a problem hiding this comment.
Why reseting post meta in each conditions?
There was a problem hiding this comment.
To avoid confliction I've added reset post data function before return
Expected 1 space after open parenthesis as per the PHPCS standard.
Expected 1 space after open parenthesis as per the PHPCS standard.
Expected 1 space after open parenthesis as per the PHPCS standard.
Fixing coding standard error as per the PHPCS
removed Whitespace
|
Please review updated code. |
2 participants
Queries pages using a specified template file and returns an array of IDs, permalinks, or titles based on the provided field parameter.
Trac ticket: https://core.trac.wordpress.org/ticket/62666