Skip to content

#63026 Reduce the bcrypt cost during testing#8453

Closed
johnbillion wants to merge 7 commits into
WordPress:trunkfrom
johnbillion:bcrypt-tests-cost
Closed

#63026 Reduce the bcrypt cost during testing#8453
johnbillion wants to merge 7 commits into
WordPress:trunkfrom
johnbillion:bcrypt-tests-cost

Conversation

@johnbillion
Copy link
Copy Markdown
Member

@johnbillion johnbillion commented Mar 4, 2025

This reduces the bcrypt cost during testing in order to speed up tests. This PR makes two main changes:

  1. Reduces the bcrypt cost during testing from the default (12 on PHP 8.4, 10 otherwise) down to 5.
    • The lowest allowable cost in PHP is 4, so 5 is used which allows the test_wp_check_password_supports_hash_with_reduced_bcrypt_cost() test to reduce the cost by 1.
    • phpunit tests are now running in nearer to 9-10 minutes than the current 13-14, a sizeable speedup.
  2. Updates the inline documentation for parameters where the PASSWORD_* constants are used. In PHP 7.2 and 7.3 these constants are integers, not strings.

Trac ticket: https://core.trac.wordpress.org/ticket/63026

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@johnbillion johnbillion marked this pull request as ready for review May 26, 2025 15:51
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@johnbillion johnbillion changed the title Attempt to reduce the bcrypt costs during testing #63026 Attempt to reduce the bcrypt costs during testing May 26, 2025
@johnbillion johnbillion changed the title #63026 Attempt to reduce the bcrypt costs during testing #63026 Reduce the bcrypt cost during testing May 26, 2025
@johnbillion
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant