Skip to content

#63170 Upgrade test adjustments#9024

Closed
johnbillion wants to merge 5 commits intoWordPress:trunkfrom
johnbillion:63170-upgrade-test-adjustments
Closed

#63170 Upgrade test adjustments#9024
johnbillion wants to merge 5 commits intoWordPress:trunkfrom
johnbillion:63170-upgrade-test-adjustments

Conversation

@johnbillion
Copy link
Copy Markdown
Member

@johnbillion johnbillion commented Jun 19, 2025

  • Switches to testing the three most recent versions in full
  • Adjusts the 6.x matrix so it only tests versions where the database version changed

Trac ticket: https://core.trac.wordpress.org/ticket/63170

@johnbillion johnbillion requested a review from desrosj June 19, 2025 22:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 19, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Copy Markdown
Member

desrosj commented Jun 19, 2025

Originally, it was intended to test all 6.x versions, but now that there's 9 of them, I agree that it doesn't make sense.

The 5.x job below the one being edited tests uses the approach of testing all 5.x releases where the database version changed on the highest and lowest releases of each PHP major.

6.0's DB version changed from 5.9's, and every other 6.x version except 6.1, 6.2, 6.6, 6.8. We should either:

  • Change the first job to test the last 3 major versions, and then test 6.0, 6.3, 6.4, and 6.5 in the second.
  • Leave the first job testing the last 2 versions and test 6.0, 6.3, 6.4, 6.5 in the second one.
    Both would need the inline docs to be updated accordingly matching the upgrade-tests-wp-5x-php-7x-mysql notes.

@johnbillion
Copy link
Copy Markdown
Member Author

@desrosj Done. Back over to you.

Comment thread .github/workflows/upgrade-testing.yml Outdated
jobs:
# Tests the full list of PHP/MySQL combinations for the last two versions of WordPress.
upgrade-tests-last-two-releases:
# Tests the full list of PHP/MySQL combinations for the three most recent versions of WordPress.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs now say three most recent, but this matrix only includes 2 versions of wp. If we want to increase this to testing the last 3 releases, we need to add 6.6.

Keeping it at just testing the 2 most recent is also probably fine. 6.6 did not see a database version update, so it would just fall out of the matrix entirely.

I don't have strong preference either way, but keeping it at 2 most recent results in trimming 32 jobs off the matrix, which is always good!

The rest of this looks good. 👍

@johnbillion
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants