#63170 Upgrade test adjustments#9024
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Originally, it was intended to test all 6.x versions, but now that there's 9 of them, I agree that it doesn't make sense. The 5.x job below the one being edited tests uses the approach of testing all 5.x releases where the database version changed on the highest and lowest releases of each PHP major. 6.0's DB version changed from 5.9's, and every other 6.x version except 6.1, 6.2, 6.6, 6.8. We should either:
|
…here the database version changed.
|
@desrosj Done. Back over to you. |
| jobs: | ||
| # Tests the full list of PHP/MySQL combinations for the last two versions of WordPress. | ||
| upgrade-tests-last-two-releases: | ||
| # Tests the full list of PHP/MySQL combinations for the three most recent versions of WordPress. |
There was a problem hiding this comment.
The docs now say three most recent, but this matrix only includes 2 versions of wp. If we want to increase this to testing the last 3 releases, we need to add 6.6.
Keeping it at just testing the 2 most recent is also probably fine. 6.6 did not see a database version update, so it would just fall out of the matrix entirely.
I don't have strong preference either way, but keeping it at 2 most recent results in trimming 32 jobs off the matrix, which is always good!
The rest of this looks good. 👍
|
Committed in https://core.trac.wordpress.org/changeset/60340 |
Trac ticket: https://core.trac.wordpress.org/ticket/63170