Skip to content

fix: resolve nav menu item validation to check for published status #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kushagra-goyal-14 wants to merge 4 commits into
base: trunk
Choose a base branch
from
+5 −1
Open

fix: resolve nav menu item validation to check for published status #9192

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb09cf8
fix: resolve nav menu item validation to check for published status
kushagra-goyal-14 Jul 4, 2025
9576fa0
fix: enhance nav menu item validation for private post access
kushagra-goyal-14 Sep 4, 2025
9f9b790
Merge branch 'trunk' into fix/menu-item-unpublish
kushagra-goyal-14 Sep 4, 2025
9fa4adf
Merge branch 'trunk' into fix/menu-item-unpublish
kushagra-goyal-14 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/nav-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ function wp_setup_nav_menu_item( $menu_item ) {
$menu_item->_invalid = true;
}

if ( 'trash' === get_post_status( $menu_item->object_id ) ) {
if ( 'publish' !== get_post_status( $menu_item->object_id ) ) {
Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to account for custom post statuses that are public.

It should probably check is_post_status_viewable( get_post_status( $menu_item->object_id ) )

Copy link
Copy Markdown
Author

@kushagra-goyal-14 kushagra-goyal-14 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterwilsoncc 👋
Any update on this ?

$menu_item->_invalid = true;
}

Expand Down
Loading