[CLI] Support staged PHP.wasm side modules#3620
Draft
adamziel wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
[Package][@php-wasm] Node
[Package][@php-wasm] Universal
[Package][@wp-playground] CLI
[Type] Documentation
adamziel
force-pushed
the
adamziel/php-wasm-side-module-extension-loading
branch
from
0316c21 to
94e808c
Compare
adamziel
force-pushed
the
adamziel/php-wasm-side-module-extension-loading
branch
from
94e808c to
e0d3db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
extension=entry.loadWithIniDirective: false.Why
Some Wasm artifacts are consumed by another runtime component instead of PHP's extension loader. They still need PR 3616's startup-time fetch/staging path, but registering them through php.ini makes PHP try to load them as PHP extensions.
Validation
npx vitest run packages/php-wasm/universal/src/lib/load-extension.spec.ts --config packages/php-wasm/universal/vite.config.tsnpx vitest run packages/php-wasm/node/src/test/with-php-extensions.spec.ts --config packages/php-wasm/node/vite.config.tsnpx vitest run packages/playground/cli/tests/php-extensions.spec.ts --config packages/playground/cli/vite.config.tsnpx tsc -p packages/php-wasm/universal/tsconfig.lib.json --noEmit