fix(examples): resolve type errors and gate examples typecheck in CI#111
Merged
Conversation
- Fix NavigateFn to use P extends Record<string, never> instead of
keyof P extends never so parameterless routes don't require a second
argument
- Add useQuery overloads so id-based queries return QueryResult<T>
(single item) and list queries return QueryResult<T[]>, fixing
property access errors on array types
- Replace navigate(route, {}) workaround calls with navigate(route)
now that the type is correct
- Fix noUncheckedIndexedAccess errors in create-work-event by using ??
with an inline fallback instead of indexing the same Record
- Add charitable-donations and create-work-event to examples setup
- Add examples typecheck to the just check target so these errors are
caught in CI before merging
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jheddings
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigateFnconditional type so parameterless routes don't require a spurious second argument (P extends Record<string, never>instead ofkeyof P extends never)useQueryoverloads to returnQueryResult<T>for id-based (single-item) queries andQueryResult<T[]>for list queries, fixing property access type errors on the resultnavigate(route, {})workaround calls in examples now that the type is correct — these were forced by the old type bugnoUncheckedIndexedAccesserrors increate-work-eventby replacingRecordindex fallbacks with?? { ... }inline defaultscharitable-donations,create-work-event) tojust setupinexamples/.justfilecd examples && just setup && npx tsc --noEmit -p tsconfig.jsonto the rootchecktarget so example type errors are caught in CI before mergingTest plan
just checkpasses (includes examples typecheck)just testpasses (399 tests)hello,directory,charitable-donations,create-work-event) load ineverywhere view🤖 Generated with Claude Code