Merge pull request #93 from Workiva/allow_analyzer_10

Allow analyzer 10

Author: btr-rmconsole-7[bot]

.github/workflows/dart_ci.yaml

@@ -1,64 +1,22 @@
-name: Dart CI
+name: CI
 
 on:
-  push:
-    branches:
-      - 'master'
-      - 'test_consume_*'
   pull_request:
+  push:
     branches:
+      - master
+    tags:
       - '**'
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        sdk: [ 2.19.6, stable, beta ]
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dart-lang/setup-dart@v1
-        with:
-          sdk: ${{ matrix.sdk }}
-      - name: Install dependencies
-        run: dart pub get
-      - name: Validate dependencies
-        run: dart run dependency_validator
-      - name: Check formatting
-        run: dart format --output=none --set-exit-if-changed .
-        if: ${{ matrix.sdk == 'stable' }}
-      - name: Analyze project source
-        run: dart analyze
-      - name: Run tests
-        run: dart test
-      - uses: anchore/sbom-action@v0
-        with:
-          path: ./
-          format: cyclonedx-json
+  # Runs analysis, formatting, and dependency validation against the dart source.
+  checks:
+    uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.14
+
+  # Generates an SBOM and uploads it via anchore/sbom-action.
+  build:
+    uses: Workiva/gha-dart-oss/.github/workflows/build.yaml@v0.1.14
 
-  # If new major versions of analyzer are released in the future and we want to
-  # be compatible with multiple majors, use this workflow to validate.
-  # NOTE: we're currently compatible with analyzer v5 and v6, but v5 is only
-  # compatible with Dart 2 and v6 is only compatible with Dart 3, so we are
-  # already testing both major versions above. Use this workflow below if we
-  # need to test compatibility across multiple analyzer majors all on Dart 3.
-  # validate_analyzer:
-  #   runs-on: ubuntu-latest
-  #   strategy:
-  #     fail-fast: false
-  #     matrix:
-  #       sdk: [ stable ]
-  #       analyzer:
-  #         - ^6.0.0
-  #         - ^7.0.0
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: dart-lang/setup-dart@v1
-  #       with:
-  #         sdk: ${{ matrix.sdk }}
-  #     - name: Update analyzer constraint to ${{ matrix.analyzer }}
-  #       run: dart pub remove analyzer && dart pub add analyzer:${{ matrix.analyzer }} && git diff pubspec.yaml
-  #     - name: Analyze project source
-  #       run: dart analyze
-  #     - name: Run tests
-  #       run: dart test
+  # Runs unit tests in dev mode.
+  unit-tests:
+    uses: Workiva/gha-dart-oss/.github/workflows/test-unit.yaml@v0.1.14

.github/workflows/dart_publish.yaml

@@ -0,0 +1,16 @@
+name: Publish
+
+on:
+  push:
+    tags:
+      - '[0-9]+.[0-9]+.[0-9]+'
+
+permissions:
+  contents: write
+  id-token: write
+  pull-requests: write
+
+jobs:
+  # Generates and uploads an SBOM, then publishes to pub.dev.
+  publish:
+    uses: Workiva/gha-dart-oss/.github/workflows/publish.yaml@v0.1.14

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.3.0](https://github.com/Workiva/dart_codemod/compare/1.2.0...1.3.0)
+
+- Allow up to analyzer 10
+
 ## [1.2.0](https://github.com/Workiva/dart_codemod/compare/1.1.0...1.2.0)
 
 - Add `PackageContextForTest` to `package:codemod/test.dart` to help test

lib/src/file_context.dart

@@ -79,6 +79,7 @@ class FileContext {
     var buffer = StringBuffer();
     for (var error in result.errors) {
       var location = result.lineInfo.getLocation(error.offset);
+      // ignore: deprecated_member_use
       buffer.writeln('  ${error.errorCode.name}: ${error.message} - '
           '${location.lineNumber}:${location.columnNumber}');
     }

pubspec.yaml

@@ -10,7 +10,7 @@ environment:
   sdk: '>=2.19.0 <4.0.0'
 
 dependencies:
-  analyzer: '>=5.13.0 <7.0.0'
+  analyzer: '>=5.13.0 <11.0.0'
   args: ^2.0.0
   glob: ^2.0.1
   io: ^1.0.0
@@ -24,8 +24,8 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.0.1
-  dart_style: ^2.0.0
-  dependency_validator: ^3.0.0
+  dart_style: '>=2.0.0 <4.0.0'
+  dependency_validator: '>=3.0.0 <6.0.0'
   meta: ^1.6.0
   mocktail: ^1.0.1
   pedantic: ^1.11.0

test_fixtures/functional/before/codemod.dart

@@ -20,7 +20,6 @@ Future<void> run(List<String> args,
   );
 }
 
-@override
 Stream<Patch> testSuggestor(FileContext context) async* {
   if (context.sourceText.startsWith('skip')) return;