updated CI, fixed issues, fixed some comments

Author: grantnelson-wf

.github/workflows/ci.yaml

@@ -16,8 +16,8 @@ concurrency:
 
 env:
   GO_VERSION: 1.21.13
-  NODE_VERSION: 18
-  GOLANGCI_VERSION: v1.53.3
+  NODE_VERSION: 24
+  GOLANGCI_VERSION: v1.59.1
   SOURCE_MAP_SUPPORT: true
   GOPATH: ${{ github.workspace }}/go
   GOPHERJS_PATH: ${{ github.workspace }}/go/src/github.com/${{ github.repository }}
@@ -71,9 +71,6 @@ jobs:
     name: Darwin Smoke
     runs-on: macos-latest
     timeout-minutes: 10
-    env:
-      # Node version '12' is not found for darwin.
-      NODE_VERSION: 20
     steps:
       - uses: actions/checkout@v4
         with:
@@ -99,11 +96,12 @@ jobs:
       - uses: actions/checkout@v4
         with:
           path: ${{ env.GOPHERJS_PATH }}
+          fetch-depth: 0
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
       - name: Install golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
           working-directory: ${{ env.GOPHERJS_PATH }}
           version: ${{ env.GOLANGCI_VERSION }}
@@ -186,7 +184,7 @@ jobs:
         filter:
           - name: non-crypto
             pattern: '-Pve "^crypto"'
-          - name: cypto
+          - name: crypto
             pattern: '-Pe "^crypto"'
     steps:
       - uses: actions/checkout@v4

.golangci.toml

@@ -1,9 +1,6 @@
 [run]
 timeout = "1m"
 
-[output]
-format = "colored-line-number"
-
 [linters]
 disable-all = true
 enable = [

compiler/natives/src/internal/testenv/testenv.go

@@ -0,0 +1,10 @@
+//go:build js
+
+package testenv
+
+// GOPHERJS: HasSrc reports whether the entire source tree is available
+// under GOROOT. Since GopherJS doesn't have the untranspiled Go source tree
+// available at runtime, this is always false.
+func HasSrc() bool {
+	return false
+}

compiler/natives/src/net/http/clientserver_test.go

@@ -7,8 +7,3 @@ import "testing"
 func testTransportGCRequest(t *testing.T, mode testMode, body bool) {
 	t.Skip("The test relies on runtime.SetFinalizer(), which is not supported by GopherJS.")
 }
-
-func testWriteHeaderAfterWrite(t *testing.T, mode testMode, hijack bool) {
-	// See: https://github.com/gopherjs/gopherjs/issues/1085
-	t.Skip("GopherJS source maps don't preserve original function names in stack traces, which this test relied on.")
-}

compiler/prelude/prelude.js

@@ -138,6 +138,16 @@ var $parseCallFrame = (frame) => {
         }
         return [fnName, "", 0, 0];
     }
+
+    // Node.js 24+ (V8) includes the receiver object name in stack traces,
+    // e.g., "Object.runtime.Callers" and "typ2.github.com/...".
+    // The `typ2` comes from prelude\types.js in `$newType`, since the `typ`
+    // in that function gets renamed by esbuild to `typ2`, or it can be named
+    // anything else when minimized. To avoid false positives, the following
+    // pattern looks for specific matches, meaning we will have some false negatives.
+    const receiverRe = /^(?:(?:Object|typ\d*)\.)|(?:[a-zA-Z_$][a-zA-Z0-9_$]*\.(github\.com[\\|/]))/;
+    const stripReceiver = (fnName) => fnName.replace(receiverRe, "$1");
+
     $parseCallFrame = (frame) => {
         // FireFox
         const atIdx = frame.indexOf("@")
@@ -163,6 +173,7 @@ var $parseCallFrame = (frame) => {
             if (closeIdx === -1) closeIdx = fnName.length;
             fnName = fnName.substring(asIdx+4, closeIdx).trim();
         }
+        fnName = stripReceiver(fnName)
 
         var closeIdx = frame.indexOf(")", openIdx);
         if (closeIdx === -1) closeIdx = frame.length;

tests/runtime_test.go

@@ -118,6 +118,26 @@ func Test_parseCallFrame(t *testing.T) {
 			input: "at https://example.com/angular.min.js:31:225",
 			want:  callFrame{FuncName: "<none>", File: "https://example.com/angular.min.js", Line: 31, Col: 225},
 		},
+		{
+			name:  "Node.js 24+ (V8) receiver prefix for package-level function",
+			input: "at Object.runtime.Callers (runtime.go:42:3)",
+			want:  callFrame{FuncName: "runtime.Callers", File: "runtime.go", Line: 42, Col: 3},
+		},
+		{
+			name:  "Node.js 24+ (V8) receiver prefix for function on type",
+			input: "at typ2.github.com/gopherjs/gopherjs/tests.callStack.capture (runtime.go:42:3)",
+			want:  callFrame{FuncName: "github.com/gopherjs/gopherjs/tests.callStack.capture", File: "runtime.go", Line: 42, Col: 3},
+		},
+		{
+			name:  "Node.js 24+ (V8) receiver prefix for function on type",
+			input: "at typ2.tests.callStack.capture (runtime.go:42:3)",
+			want:  callFrame{FuncName: "tests.callStack.capture", File: "runtime.go", Line: 42, Col: 3},
+		},
+		{
+			name:  "Node.js 24+ (V8) receiver prefix for function on type when minified",
+			input: "at r.github.com/gopherjs/gopherjs/tests.callStack.capture (runtime.go:42:3)",
+			want:  callFrame{FuncName: "github.com/gopherjs/gopherjs/tests.callStack.capture", File: "runtime.go", Line: 42, Col: 3},
+		},
 	}
 
 	for _, tt := range tests {
@@ -169,8 +189,8 @@ func (c *callStack) capture(amount int) {
 func TestCallers(t *testing.T) {
 	// Some of the GopherJS function names don't match upstream Go, or even the
 	// function names in the Go source when minified.
-	// Until https://github.com/gopherjs/gopherjs/issues/1085 is resolved, the
-	// mismatch is difficult to avoid, but we can at least use "masked" frames to
+	// In some cases the mismatch is difficult to avoid even with source maps,
+	// but we can at least use "masked" frames to
 	// make sure the number of frames matches expected.
 	opts := cmp.Comparer(func(a, b funcName) bool {
 		if a == masked("") || b == masked("") {

tests/shadowing_test.go

@@ -53,7 +53,7 @@ func Test_AssertType_ImplementedBy(t *testing.T) {
 // This is similar to `Test_AssertType_ImplementedBy` except the loop gaurd,
 // `seen`, in `$methodSet` was using `e.typ.string` as the key, which caused
 // this test to fail since the `Container`s here both have the string
-// `*tests.Containers`. The way they are embedded caused the inner most one
+// `*tests.Container`. The way they are embedded caused the inner most one
 // that defines `func Do() string` to be skipped, thus the cast didn't work.
 // Switching the key to `e.typ.id` fixes this issue.
 func Test_MethodSet_Seen(t *testing.T) {
@@ -146,7 +146,7 @@ type Shadow5Container struct{ *DoEmbedded }
 
 func (e *Shadow5Container) Do() string { return `Try to do` }
 
-// `Container5.Do` shadows `DoEmbedded.Do`.
+// `Shadow5Container.Do` shadows `DoEmbedded.Do`.
 func Test_Shadow5(t *testing.T) {
 	c := &Shadow5Container{}
 	shadowCheck(t, c, `Try to do`)