Skip to content

Commit 16b9057

Browse files
btr-rmconsole-7[bot]btr-rmconsole-7[bot]
authored
Merge pull request #998 from Workiva/functional-builder-tests
FED-4419 Migrate builder test to functional test, refactor gold file setup
2 parents 655ba49 + 84000e2 commit 16b9057

60 files changed

Lines changed: 194 additions & 251 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ jobs:
5353
DART_VERSION="${{ steps.setup-dart.outputs.dart-version }}"
5454
if [[ "$DART_VERSION" =~ ^3 ]]; then
5555
./tool/delete_dart_2_only_files.sh
56-
./tool/update_tests_for_dart_3.sh
5756
# Stage these changes so they don't show up in the generated file `git diff` check below
5857
git add .
5958
fi
@@ -146,7 +145,6 @@ jobs:
146145
DART_VERSION="${{ steps.setup-dart.outputs.dart-version }}"
147146
if [[ "$DART_VERSION" =~ ^3 ]]; then
148147
./tool/delete_dart_2_only_files.sh
149-
./tool/update_tests_for_dart_3.sh
150148
fi
151149
152150
- name: Analyze package source
@@ -196,7 +194,7 @@ jobs:
196194
run: |
197195
DART_VERSION="${{ steps.setup-dart.outputs.dart-version }}"
198196
if [[ "$DART_VERSION" =~ ^3 ]]; then
199-
(cd ../.. && ./tool/delete_dart_2_only_files.sh && ./tool/update_tests_for_dart_3.sh)
197+
(cd ../.. && ./tool/delete_dart_2_only_files.sh)
200198
fi
201199
202200
- name: Validate dependencies

‎test/vm_tests/builder/over_react_builder_test.dart‎

Lines changed: 126 additions & 147 deletions
Large diffs are not rendered by default.

‎test_fixtures/gold_output_files/README.md‎

Lines changed: 0 additions & 5 deletions

‎test_fixtures/gold_output_files/backwards_compatible/basic.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'basic.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
// React component factory implementation.

‎test_fixtures/gold_output_files/backwards_compatible/basic_library.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'basic_library.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
// React component factory implementation.

‎test_fixtures/gold_output_files/backwards_compatible/props_mixin.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'props_mixin.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
mixin $ExamplePropsMixinClass implements ExamplePropsMixinClass {

‎test_fixtures/gold_output_files/backwards_compatible/state_mixin.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'state_mixin.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
mixin $ExampleStateMixinClass implements ExampleStateMixinClass {

‎test_fixtures/gold_output_files/dart2_only/basic.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'basic.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
// React component factory implementation.

‎test_fixtures/gold_output_files/dart2_only/basic_library.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'basic_library.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
// React component factory implementation.

‎test_fixtures/gold_output_files/dart2_only/component2/basic.over_react.g.dart.goldFile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ part of 'basic.dart';
66

77
// **************************************************************************
88
// OverReactBuilder (package:over_react/src/builder.dart)
9+
//
10+
// Using nullSafety: false. {languageVersion: 2.11, source: libraryVersionComment}
911
// **************************************************************************
1012

1113
// React component factory implementation.

0 commit comments

Comments
 (0)