Skip to content

Commit 4ff1ece

Browse files
Merge pull request #42 from Workiva/batch/cplat/raise_more_max_versions
Raise More Max Versions
2 parents 95008bc + 77ce6cd commit 4ff1ece

6 files changed

Lines changed: 24 additions & 36 deletions

File tree

.github/workflows/dart_ci.yaml

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: ubuntu-latest
1515
strategy:
1616
matrix:
17-
sdk: [ stable, beta, dev ]
17+
sdk: [ 2.13.4, stable, beta, dev ]
1818
steps:
1919
- uses: actions/checkout@v2
2020
- uses: actions/setup-node@v2
@@ -29,33 +29,10 @@ jobs:
2929
run: dart pub get
3030
- name: Validate dependencies
3131
run: dart run dependency_validator
32-
- name: Analyze project source
33-
run: dart analyze
34-
- name: Run tests
35-
run: dart run dart_dev test
36-
37-
test_old_sdks:
38-
runs-on: ubuntu-latest
39-
strategy:
40-
matrix:
41-
sdk: [2.13.4]
42-
steps:
43-
- uses: actions/checkout@v2
44-
- uses: actions/setup-node@v2
45-
with:
46-
node-version: '15'
47-
- uses: dart-lang/setup-dart@v1
48-
with:
49-
sdk: ${{ matrix.sdk }}
50-
- name: Install Node dependencies
51-
run: npm install
52-
- name: Install Dart dependencies
53-
run: pub get
54-
- name: Validate dependencies
55-
run: pub run dependency_validator
5632
- name: Check formatting
5733
run: dart format --output=none --set-exit-if-changed .
34+
if: ${{ matrix.sdk == 'stable' }}
5835
- name: Analyze project source
59-
run: dartanalyzer .
36+
run: dart analyze
6037
- name: Run tests
61-
run: pub run dart_dev test
38+
run: dart run dart_dev test

CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
1-
## 1.1.4
1+
## 1.1.8
2+
3+
- Dependency upgrades.
4+
- Simplify Github CI workflow.
5+
- Formatting and analysis lints.
6+
7+
## 1.1.6
8+
9+
- Replace deprecated `pub` commands
10+
11+
## 1.1.4 - 1.1.5
212

313
- Dependency upgrades.
414

pubspec.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ environment:
88

99
dependencies:
1010
js: ^0.6.1
11-
w_common: ^1.20.1
11+
w_common: '>=1.20.1 <3.0.0'
1212

1313
dev_dependencies:
14-
build_runner: '>=1.10.0 <3.0.0'
15-
build_test: '>=0.10.9 <2.0.0'
16-
build_web_compilers: ^2.12.0
14+
build_runner: ^2.1.2
15+
build_test: ^2.1.3
16+
build_web_compilers: ^3.0.0
1717
dart_dev: ^3.6.5
18-
dependency_validator: ^2.0.1
18+
dependency_validator: ^3.2.0
1919
test: ^1.15.7
2020
workiva_analysis_options: ^1.1.0

test/missing_sockjs_lib_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
@TestOn('browser')
1616
library sockjs_client.test.sockjs_client_test;
1717

18-
import 'package:sockjs_client_wrapper/sockjs_client_wrapper.dart';
1918
import 'package:test/test.dart';
2019

2120
import 'package:sockjs_client_wrapper/src/client.dart';

test/sockjs_client_wrapper_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ library sockjs_client.test.sockjs_client_test;
1818

1919
import 'dart:async';
2020

21-
import 'package:sockjs_client_wrapper/sockjs_client_wrapper.dart';
2221
import 'package:test/test.dart';
2322

2423
import 'package:sockjs_client_wrapper/src/client.dart';
@@ -130,7 +129,9 @@ void _integrationSuite(
130129
c.complete();
131130
}
132131
});
133-
client..send('message1')..send('message2');
132+
client
133+
..send('message1')
134+
..send('message2');
134135

135136
await c.future;
136137
client.close();

tool/dart_dev/config.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import 'package:dart_dev/dart_dev.dart';
1919

2020
final config = {
2121
...coreConfig,
22+
'format': FormatTool()..formatter = Formatter.dartFormat,
2223
'test': CompoundTool()
2324
..addTool(DevTool.fromFunction(startTestServer), alwaysRun: true)
2425
..addTool(TestTool(), argMapper: takeAllArgs)

0 commit comments

Comments
 (0)