Skip to content

Commit 68c5ac4

Browse files
committed
Remove unneeded convo logic dep + tags cache tests
1 parent d845001 commit 68c5ac4

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

src/sidebar/annotations-sidebar/containers/logic.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,6 @@ export class SidebarContainerLogic extends UILogic<
144144
},
145145
getSharedAnnotationLinkID: ({ id }) =>
146146
typeof id === 'string' ? id : id.toString(),
147-
getOrCreateConversationThread: async ({
148-
annotationReference,
149-
...params
150-
}) =>
151-
options.contentConversationsBG.getOrCreateThread({
152-
...params,
153-
sharedAnnotationReference: annotationReference,
154-
}),
155147
getRepliesByAnnotation: async ({
156148
annotationReference,
157149
sharedListReference,

src/tags/background/storage.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe('Tags background interface', () => {
8282
})
8383
})
8484

85-
describe('Tag Cache', () => {
85+
describe.skip('Tag Cache', () => {
8686
async function setupTest() {
8787
const setup = await setupBackgroundIntegrationTest({
8888
includePostSyncProcessor: true,
@@ -91,7 +91,7 @@ describe('Tag Cache', () => {
9191
return { tagsModule }
9292
}
9393

94-
describe('modifies cache', () => {
94+
describe.skip('modifies cache', () => {
9595
test('add tags', async () => {
9696
const { tagsModule } = await setupTest()
9797
const { tag, url } = DATA.TAGS_1

0 commit comments

Comments
 (0)