Fix issue if no positions in PhaseLine determineLabelPositions method.

[wcmatthysen]

Description of the Change

The MilStd2525GraphicFactory class can create graphics without positions. As a result of this there is a bug in the PhaseLine class where a NPE is thrown.

Why Should This Be In Core?

The null-pointer check is an oversight that should have been in the original class.

Benefits

General stability of MilStd2525-related classes.

Potential Drawbacks

None

Applicable Issues

None

[wcmatthysen]

@emxsys, I just need to sort out the formatting. I can do that and merge if everything looks alright to you.

[emxsys]

@wcmatthysen Looks OK with a fix the formatting. For your consideration, should we file (and fix) a bug for this in the issue tracker? It seems redundant for small changes like this, but it makes for good record keeping.

[wcmatthysen]

I think it makes for good PR in terms of getting people involved in the project. If we reference their work and create pull requests for these changes it might create some good-will with the community. They get to see their changes being merged in, and might be more willing to contribute additional changes in the future.

However, I agree. The overhead might be a bit hectic if a review is needed for every single small change. So, for small changes like these where the change has low impact and clearly fixes a problem, I can create the pull-request and just do the merge directly (without the code-review).

[PJHogan]

:~}}}